Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hyperparamter sweep to sweep.py; Fall back to eig when eigh fails #235

Merged
merged 15 commits into from
May 5, 2023
Merged

Add hyperparamter sweep to sweep.py; Fall back to eig when eigh fails #235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c79f47d
reduced reporter filesize by 4x; still unsure why the pickle file sto…
AlexTMallen Apr 27, 2023
dca33b3
add save_reporter_stats CLA
AlexTMallen Apr 27, 2023
b497f5f
Merge branch 'light-reporter-saving' into hparam-grid
AlexTMallen Apr 29, 2023
9705ffb
sweep hparam_step working
AlexTMallen Apr 29, 2023
bbebfc0
fix out_dir naming, skipping supervised
AlexTMallen Apr 29, 2023
4352986
use regular eig as backup for eigh
AlexTMallen Apr 29, 2023
60f6509
split hparam directories vertically
AlexTMallen Apr 30, 2023
6c11818
Merge branch 'main' into hparam-grid
AlexTMallen May 1, 2023
2817f15
remove duplicate line
AlexTMallen May 1, 2023
b0193fa
fix num_variants arg
AlexTMallen May 1, 2023
ae85dba
also pass num_shots into prompt_loader
AlexTMallen May 1, 2023
241370a
Merge branch 'main' into hparam-grid
AlexTMallen May 2, 2023
1d6ae33
merge main into hparam-grid
AlexTMallen May 3, 2023
c5980a4
Remove superfluous assert
norabelrose May 5, 2023
d9185e3
Merge remote-tracking branch 'origin/main' into hparam-grid
norabelrose May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add save_reporter_stats CLA
  • Loading branch information
@AlexTMallen
AlexTMallen committed Apr 27, 2023
commit dca33b306f4f52eb8943beeb948dabce0b321de2
2 changes: 1 addition & 1 deletion elk/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Run(ABC, Serializable):

concatenated_layer_offset: int = 0
debug: bool = False
min_gpu_mem: int | None = None
min_gpu_mem: int | None = None # in bytes
num_gpus: int = -1
out_dir: Path | None = None
disable_cache: bool = field(default=False, to_dict=False)
Expand Down
5 changes: 3 additions & 2 deletions elk/training/eigen_reporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class EigenReporterConfig(ReporterConfig):
neg_cov_weight: float = 0.5

num_heads: int = 1
save_reporter_stats: bool = False

def __post_init__(self):
if not (0 <= self.neg_cov_weight <= 1):
Expand Down Expand Up @@ -312,8 +313,8 @@ def closure():

opt.step(closure)

def save(self, path: Path | str, save_stats=False):
def save(self, path: Path | str):
# TODO: this method will save separate JSON and PT files
if not save_stats:
if not self.config.save_reporter_stats:
self.delete_stats()
super().save(path)