Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hyperparamter sweep to sweep.py; Fall back to eig when eigh fails #235

Merged
merged 15 commits into from
May 5, 2023
Merged

Add hyperparamter sweep to sweep.py; Fall back to eig when eigh fails #235

merged 15 commits into from
May 5, 2023

Conversation

AlexTMallen
Copy link
Collaborator

This also incorporates my 4x smaller reporters change, and falls back to torch.linalg.eig when there's an error with eigh.

@AlexTMallen AlexTMallen changed the title Add hyperparamter sweep to sweep.py Add hyperparamter sweep to sweep.py; Fall back to eig when eigh fails May 4, 2023
norabelrose
norabelrose approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norabelrose norabelrose merged commit 2509092 into main May 5, 2023
4 checks passed
@norabelrose norabelrose deleted the hparam-grid branch May 5, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norabelrose norabelrose norabelrose approved these changes

@lauritowal lauritowal Awaiting requested review from lauritowal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexTMallen @norabelrose