Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: PromptDataset inserting fake labels into its output #127

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix: PromptDataset inserting fake labels into its output #127

merged 1 commit into from
Mar 15, 2023

Conversation

AlexTMallen
Copy link
Collaborator

This bug affects all previous experiments with num_variants>1.

@AlexTMallen AlexTMallen added the bug Something isn't working label Mar 15, 2023
@AlexTMallen AlexTMallen mentioned this pull request Mar 15, 2023
Merged
norabelrose
norabelrose approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norabelrose norabelrose merged commit 2c6a10a into main Mar 15, 2023
@norabelrose norabelrose deleted the hotfix/promptdataset-fakes-labels branch March 15, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norabelrose norabelrose norabelrose approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexTMallen @norabelrose