Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort outputs by variant id during extraction #122

Merged
merged 9 commits into from
Mar 17, 2023
Merged

Conversation

AlexTMallen
Copy link
Collaborator

This enables all the hiddens in a particular "row" (index into the num_variants axis) to be of the same variant when using all available templates.

Note that when num_variants is less than the number of available templates, it will continue to be the case that different subsets of the templates will be used for each example.

@AlexTMallen
Copy link
Collaborator Author

It turns out that the quality of trained LR and VINC models depends sensitively on the shuffling of the prompts--I haven't yet totally figured out what's going on but I have verified that the only difference between the two cases was the data ordering.

@AlexTMallen
Copy link
Collaborator Author

This sensitivity turns out to be explained by the bug fixed in #127

Copy link
Member

@norabelrose norabelrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexTMallen AlexTMallen merged commit 3af509b into main Mar 17, 2023
@AlexTMallen AlexTMallen deleted the sort-variant branch March 17, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants