Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi datasets #123

Merged
merged 46 commits into from
Mar 28, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
681698d
add multiple datasets support
Benw8888 Mar 9, 2023
ac1b9f1
Merge branch 'main' of github.com:EleutherAI/elk into multi-datasets
Benw8888 Mar 9, 2023
b864c77
train_reporter works on a list of layers now
Benw8888 Mar 10, 2023
7d7d97c
changing printed layer names
Benw8888 Mar 10, 2023
4fe61e9
fixed concatenation bug
Benw8888 Mar 11, 2023
fe61d67
minor edits
Benw8888 Mar 13, 2023
74da878
fixed pyright issues
Benw8888 Mar 13, 2023
569ef05
Merge branch 'main' of github.com:EleutherAI/elk into multi-datasets
Benw8888 Mar 14, 2023
b62b679
Merge branch 'main' into multi-datasets
norabelrose Mar 20, 2023
fe94c22
Fix tests
norabelrose Mar 20, 2023
bba24d8
Now working sorta
norabelrose Mar 22, 2023
03ba6e0
Skip slow BalancedBatchSampler test
norabelrose Mar 22, 2023
15ab351
Slightly relax test_output_is_roughly_balanced
norabelrose Mar 22, 2023
a80369e
Make BalancedSampler deterministic
norabelrose Mar 22, 2023
d304ab3
InitVar
norabelrose Mar 22, 2023
761c82d
Support multi class again
norabelrose Mar 22, 2023
f29743b
Fix naming issue
norabelrose Mar 22, 2023
b7b7e23
Support few shot prompts
norabelrose Mar 23, 2023
1afb563
Merge branch 'main' into multi-datasets
norabelrose Mar 23, 2023
225d4c7
fix multiclass labels
AlexTMallen Mar 23, 2023
9368dc8
Merge branch 'multi-datasets' of github.com:EleutherAI/elk into multi…
AlexTMallen Mar 23, 2023
a858b65
Merge branch 'main' into multi-datasets
norabelrose Mar 24, 2023
5dc2ec6
Merge branch 'multi-datasets' of github.com:EleutherAI/elk into multi…
norabelrose Mar 24, 2023
b1b95e5
Fix dumb part of test failures
norabelrose Mar 25, 2023
ee3911e
Fix assert_allclose warning
norabelrose Mar 25, 2023
a55b3de
Switch to torch.testing.assert_close in EigenReporter test
norabelrose Mar 25, 2023
44dc25c
Shuffle load_prompts output by default
norabelrose Mar 25, 2023
93d8d87
Fix smoke test failure
norabelrose Mar 25, 2023
fad4d74
Remove debug prints
AlexTMallen Mar 25, 2023
0a054f4
Remove more debug print statements
AlexTMallen Mar 25, 2023
177eec2
make min_memory usable; broadcast mmax_examples in __post_init__
AlexTMallen Mar 26, 2023
3a762b0
prompt loading refactor to enable better streaming
AlexTMallen Mar 26, 2023
f66c054
remove shuffle arg
AlexTMallen Mar 26, 2023
d3d87fc
remove unused @dataclass
lauritowal Mar 26, 2023
3d08147
merge
lauritowal Mar 27, 2023
c9a43e1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 27, 2023
94290aa
add concatenated_layer_offset to eval
lauritowal Mar 27, 2023
f9298e4
Merge branch 'multi-datasets' of https://github.com/EleutherAI/elk in…
lauritowal Mar 27, 2023
3765c4f
add self.
lauritowal Mar 27, 2023
2b05193
replace target with data
lauritowal Mar 27, 2023
83731bb
add self.
lauritowal Mar 27, 2023
764fda9
remove second arg
lauritowal Mar 27, 2023
d2c66b0
fix passing the wrong params for world size / rank
thejaminator Mar 28, 2023
9186326
Update prompt_loading.py
lauritowal Mar 28, 2023
3f99a4d
fix pre-commit errors
lauritowal Mar 28, 2023
148130d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor edits
  • Loading branch information
Benw8888 committed Mar 13, 2023
commit fe61d67cc335417ce0bda639690563208b66bb07
18 changes: 9 additions & 9 deletions elk/extraction/prompt_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,15 @@ def __init__(
# This allows you to just set split="train" and split="test" for any dataset
# and not worry about train-test leakage.

# split_name, *others = ds_dict.keys()
# if not others:
# print("Creating a 75/25 train-test split...")
split_name, *others = ds_dict.keys()
if not others:
print("Creating a 75/25 train-test split...")

# # Don't shuffle now because we're going to shuffle later
# ds_dict = ds_dict[split_name].train_test_split(
# seed=cfg.seed, shuffle=False, stratify_by_column=cfg.label_column
# )
# assert isinstance(ds_dict, DatasetDict)
# Don't shuffle now because we're going to shuffle later
ds_dict = ds_dict[split_name].train_test_split(
seed=cfg.seed, shuffle=False, stratify_by_column=cfg.label_column
)
assert isinstance(ds_dict, DatasetDict)

# The 'active' split is the one that gets queried by __getitem__
self.active_split = ds_dict[split]
Expand Down Expand Up @@ -254,7 +254,7 @@ def num_classes(self) -> int:
return self.active_split.features[self.label_column].num_classes


class Interleaved_Datasets(TorchDataset):
class InterleavedDatasets(TorchDataset):
def __init__(
self,
datasets: list[PromptDataset],
Expand Down
9 changes: 5 additions & 4 deletions elk/training/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ def train_reporter(
cfg: RunConfig,
dataset: DatasetDict,
out_dir: Path,
layer: Union[int, list[int]],
layer: list[int],
norabelrose marked this conversation as resolved.
Show resolved Hide resolved
devices: list[str],
world_size: int = 1,
):
"""Train a single reporter on a single layer, or a list of layers."""

# Reproducibility
seed = cfg.net.seed + layer if isinstance(layer, int) else layer[0]
seed = cfg.net.seed + layer[0]
np.random.seed(seed)
random.seed(seed)
torch.manual_seed(seed)
Expand Down Expand Up @@ -180,16 +180,17 @@ def train(cfg: RunConfig, out_dir: Optional[Path] = None):
if not cfg.skip_baseline:
cols += ["lr_auroc", "lr_acc"]

# Create subsets of layers to train reporters on
layers = [
int(feat[len("hidden_") :])
[int(feat[len("hidden_") :])]
for feat in ds["train"].features
if feat.startswith("hidden_")
]

# concatenate hidden states from a previous layer, if told to
if cfg.concatenate_layers > 0:
for i in range(cfg.concatenate_layers, len(layers)):
layers[i] = [layers[i], layers[i] - cfg.concatenate_layers]
layers[i] = layers[i] + [layers[i][0] - cfg.concatenate_layers]

# Train reporters for each layer in parallel
with mp.Pool(num_devices) as pool, open(out_dir / "eval.csv", "w") as f:
Expand Down