Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi datasets #123

Merged
merged 46 commits into from
Mar 28, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
681698d
add multiple datasets support
Benw8888 Mar 9, 2023
ac1b9f1
Merge branch 'main' of github.com:EleutherAI/elk into multi-datasets
Benw8888 Mar 9, 2023
b864c77
train_reporter works on a list of layers now
Benw8888 Mar 10, 2023
7d7d97c
changing printed layer names
Benw8888 Mar 10, 2023
4fe61e9
fixed concatenation bug
Benw8888 Mar 11, 2023
fe61d67
minor edits
Benw8888 Mar 13, 2023
74da878
fixed pyright issues
Benw8888 Mar 13, 2023
569ef05
Merge branch 'main' of github.com:EleutherAI/elk into multi-datasets
Benw8888 Mar 14, 2023
b62b679
Merge branch 'main' into multi-datasets
norabelrose Mar 20, 2023
fe94c22
Fix tests
norabelrose Mar 20, 2023
bba24d8
Now working sorta
norabelrose Mar 22, 2023
03ba6e0
Skip slow BalancedBatchSampler test
norabelrose Mar 22, 2023
15ab351
Slightly relax test_output_is_roughly_balanced
norabelrose Mar 22, 2023
a80369e
Make BalancedSampler deterministic
norabelrose Mar 22, 2023
d304ab3
InitVar
norabelrose Mar 22, 2023
761c82d
Support multi class again
norabelrose Mar 22, 2023
f29743b
Fix naming issue
norabelrose Mar 22, 2023
b7b7e23
Support few shot prompts
norabelrose Mar 23, 2023
1afb563
Merge branch 'main' into multi-datasets
norabelrose Mar 23, 2023
225d4c7
fix multiclass labels
AlexTMallen Mar 23, 2023
9368dc8
Merge branch 'multi-datasets' of github.com:EleutherAI/elk into multi…
AlexTMallen Mar 23, 2023
a858b65
Merge branch 'main' into multi-datasets
norabelrose Mar 24, 2023
5dc2ec6
Merge branch 'multi-datasets' of github.com:EleutherAI/elk into multi…
norabelrose Mar 24, 2023
b1b95e5
Fix dumb part of test failures
norabelrose Mar 25, 2023
ee3911e
Fix assert_allclose warning
norabelrose Mar 25, 2023
a55b3de
Switch to torch.testing.assert_close in EigenReporter test
norabelrose Mar 25, 2023
44dc25c
Shuffle load_prompts output by default
norabelrose Mar 25, 2023
93d8d87
Fix smoke test failure
norabelrose Mar 25, 2023
fad4d74
Remove debug prints
AlexTMallen Mar 25, 2023
0a054f4
Remove more debug print statements
AlexTMallen Mar 25, 2023
177eec2
make min_memory usable; broadcast mmax_examples in __post_init__
AlexTMallen Mar 26, 2023
3a762b0
prompt loading refactor to enable better streaming
AlexTMallen Mar 26, 2023
f66c054
remove shuffle arg
AlexTMallen Mar 26, 2023
d3d87fc
remove unused @dataclass
lauritowal Mar 26, 2023
3d08147
merge
lauritowal Mar 27, 2023
c9a43e1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 27, 2023
94290aa
add concatenated_layer_offset to eval
lauritowal Mar 27, 2023
f9298e4
Merge branch 'multi-datasets' of https://github.com/EleutherAI/elk in…
lauritowal Mar 27, 2023
3765c4f
add self.
lauritowal Mar 27, 2023
2b05193
replace target with data
lauritowal Mar 27, 2023
83731bb
add self.
lauritowal Mar 27, 2023
764fda9
remove second arg
lauritowal Mar 27, 2023
d2c66b0
fix passing the wrong params for world size / rank
thejaminator Mar 28, 2023
9186326
Update prompt_loading.py
lauritowal Mar 28, 2023
3f99a4d
fix pre-commit errors
lauritowal Mar 28, 2023
148130d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Now working sorta
  • Loading branch information
norabelrose committed Mar 22, 2023
commit bba24d8efe2b5d38a407b12169508155da885d0b
2 changes: 1 addition & 1 deletion elk/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
from .extraction import extract_hiddens, ExtractionConfig, PromptDataset
from .extraction import extract_hiddens, ExtractionConfig
2 changes: 1 addition & 1 deletion elk/__main__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Main entry point for `elk`."""

from .extraction import extract, ExtractionConfig
from elk.evaluation.evaluate import EvaluateConfig, evaluate_reporters
from .evaluation.evaluate import EvaluateConfig, evaluate_reporters
from .training import RunConfig
from .training.train import train
from pathlib import Path
Expand Down
Empty file added elk/evaluation/__init__.py
Empty file.
19 changes: 7 additions & 12 deletions elk/evaluation/evaluate.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,16 @@
import csv
import os
import pickle
from ..training.preprocessing import normalize
from dataclasses import dataclass
from datasets import DatasetDict
from functools import partial
from hashlib import md5
from pathlib import Path
from typing import List, Literal, Optional, cast

import torch
import torch.multiprocessing as mp
import yaml
from simple_parsing.helpers import Serializable, field
from torch import Tensor
from tqdm.auto import tqdm

from datasets import DatasetDict
from elk.training.preprocessing import normalize
from typing import Literal, Optional, cast
import csv
import os
import torch
import torch.multiprocessing as mp

from ..extraction import ExtractionConfig, extract
from ..files import elk_reporter_dir, memorably_named_dir
Expand Down
3 changes: 2 additions & 1 deletion elk/extraction/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from .balanced_sampler import BalancedBatchSampler, BalancedSampler
from .extraction import ExtractionConfig, extract_hiddens, extract
from .generator import _GeneratorConfig, _GeneratorBuilder
from .prompt_dataset import PromptDataset, PromptConfig
from .prompt_loading import PromptConfig, load_prompts
83 changes: 83 additions & 0 deletions elk/extraction/balanced_sampler.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
from ..utils import infer_label_column
from collections import Counter
from datasets import IterableDataset
from itertools import cycle
from torch.utils.data import IterableDataset as TorchIterableDataset
from typing import Iterator, Optional
import numpy as np


class BalancedSampler(TorchIterableDataset):
"""
Approximately balances a binary classification dataset in a streaming fashion.
Written mostly by GPT-4.

Args:
dataset (IterableDataset): The HuggingFace IterableDataset to balance.
label_col (Optional[str], optional): The name of the column containing the
binary label. If not provided, the label column will be inferred from
the dataset features. Defaults to None.
buffer_size (int, optional): The total buffer size to use for balancing the
dataset. This value should be divisible by 2, as it will be equally
divided between the two binary label values (0 and 1). Defaults to 1000.
"""

def __init__(self, dataset: IterableDataset):
self.dataset = dataset
self.class_counts = np.zeros(2)

def __iter__(self):
for sample in self.dataset:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the dataset we're streaming from isn't shuffled (e.g. all the movie reviews about batman come first) our sampling will be distributionally incorrect, no?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also one of the tests broke.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah working on the test thing, it's a pretty bizarre error.

The shuffling isn't really an issue. See the HF docs on this https://huggingface.co/docs/datasets/stream#shuffle. We just need to make sure we're actually calling .shuffle, which I thought we were, but it's entirely possible I'm just misremembering.

label = sample["label"]

# Update class counts
self.class_counts[label] += 1
current_balance = self.class_counts / self.class_counts.sum()

# Check if the sample should be dropped
majority_class = np.argmax(current_balance)
if label == majority_class:
# Solution of n * p * q / [n * (1 - p) + n * p * q] = 0.5 for q
keep_prob = 1 / current_balance[majority_class] - 1
if np.random.rand() < 1 - keep_prob:
continue

yield sample


class BalancedBatchSampler:
"""Yields precisely balanced batches from a binary classification dataset.

Written by a human being because GPT-4 couldn't figure out how to do it.
"""

def __init__(
self,
dataset: IterableDataset,
label_col: Optional[str] = None,
batch_size: int = 32,
):
self.batch_size = batch_size
self.dataset = dataset
self.label_col = label_col or infer_label_column(dataset.features)

def __iter__(self) -> Iterator[list[dict]]:
batch = []

max_count = self.batch_size // 2
label_counts = Counter()

# Infinite loop!
for sample in cycle(self.dataset):
label = sample[self.label_col]
if label_counts[label] >= max_count:
continue

batch.append(sample)
label_counts[label] += 1

if len(batch) == self.batch_size:
yield batch

batch = []
label_counts.clear()
Loading