Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/trace/api: add support for Unix Domain Sockets #3556

Merged
merged 2 commits into from
Jul 10, 2019
Merged

pkg/trace/api: add support for Unix Domain Sockets #3556

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f76ee
pkg/trace/api: add support for Unix Domain Sockets
gbbr May 23, 2019
51bc1f8
Addressed PR comments.
gbbr Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Addressed PR comments.
  • Loading branch information
@gbbr
gbbr committed Jul 10, 2019
commit 51bc1f8cefa38d203abe5cba34236ee23356c27f
4 changes: 2 additions & 2 deletions pkg/trace/api/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func (r *HTTPReceiver) attachDebugHandlers(mux *http.ServeMux) {
mux.Handle("/debug/vars", expvar.Handler())
}

// listenUnix returns a *net.Listener listening on the given "unix" socket path.
// listenUnix returns a net.Listener listening on the given "unix" socket path.
func (r *HTTPReceiver) listenUnix(path string) (net.Listener, error) {
fi, err := os.Stat(path)
if err == nil {
Expand All @@ -227,7 +227,7 @@ func (r *HTTPReceiver) listenUnix(path string) (net.Listener, error) {
return ln, err
}

// listenTCP creates a new HTTP server listening on the provided TCP address.
// listenTCP creates a new net.Listener on the provided TCP address.
func (r *HTTPReceiver) listenTCP(addr string) (net.Listener, error) {
tcpln, err := net.Listen("tcp", addr)
if err != nil {
Expand Down