pkg/trace/api: add support for Unix Domain Sockets #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/uds
branch
2 times, most recently
from
31a768b
to
b777357
Compare
|
We should consider whether we need to introduce the |
gbbr
added a commit
that referenced
this pull request
May 27, 2019
This is an APM-only custom build of the agent, containing the latest Datadog Agent release (6.11.2) and the APM development branch from #3556. It was created by running: git checkout 6.11.2 git checkout gbbr/uds -- pkg/trace # clean up rm pkg/trace/writer/payload* pkg/watchdog/net.go rm pkg/trace/watchdog/info_nix_test.go
gbbr
force-pushed
the
gbbr/uds
branch
5 times, most recently
from
b6148c6
to
8a679a9
Compare
This change adds support for Unix Domain Sockets by means of a
configuration setting. By default, this feature is disabled. To enable
it, simply point the yaml setting to the right socket path, for example:
apm_config:
receiver_socket: /tmp/trace.sock
This will enable the HTTP server to listen on unix:https:///tmp/trace.sock
The DD_APM_RECEIVER_SOCKET environment variable is an alias for the
above.
erichgess
reviewed
Jul 10, 2019
gbbr
commented
Jul 10, 2019
erichgess
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for Unix Domain Sockets by means of a
configuration setting. By default, this feature is disabled. To enable
it, simply point the yaml setting to the right socket path, for example:
This will enable the HTTP server to listen on unix:https:///tmp/trace.sock