Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenabling equity tests #84

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Reenabling equity tests #84

merged 5 commits into from
Jul 6, 2023

Conversation

JMGilbert
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #84 (e3f9778) into dscim-v0.4.0_fixes (58682cc) will increase coverage by 2.12%.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##           dscim-v0.4.0_fixes      #84      +/-   ##
======================================================
+ Coverage               68.15%   70.28%   +2.12%     
======================================================
  Files                      17       17              
  Lines                    1878     1878              
======================================================
+ Hits                     1280     1320      +40     
+ Misses                    598      558      -40     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JMGilbert JMGilbert marked this pull request as ready for review June 20, 2023 20:54
Copy link
Member

@kemccusker kemccusker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For future, let's revisit the tolerances on the SCGHG test and whether we want to update that.

Base automatically changed from dscim-v0.4.0_fixes to dscim-v0.4.0 July 6, 2023 17:53
@kemccusker
Copy link
Member

Revisit tolerances in a later PR.

@kemccusker kemccusker merged commit 74737f5 into dscim-v0.4.0 Jul 6, 2023
4 checks passed
@JMGilbert JMGilbert deleted the equity_tests branch July 6, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants