Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit tolerances in assert_allclose in SCC and points tests #88

Open
kemccusker opened this issue Jul 6, 2023 · 0 comments
Open

revisit tolerances in assert_allclose in SCC and points tests #88

kemccusker opened this issue Jul 6, 2023 · 0 comments
Labels

Comments

@kemccusker
Copy link
Member

e.g. see in tests/test_equity.py

assert_allclose(
        expected.transpose(*sorted(expected.dims)).sortby(list(expected.dims)),
        actual.transpose(*sorted(actual.dims)).sortby(list(actual.dims)),
        rtol=1e-4,
        atol=1e-4,
    )

Tolerances are larger than for other tests. Confirm this is what we need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant