Remove/update deprecated files

[durack1]

I've just pulled down the 2.0.0 source and noted the files TODO.txt and Changes.txt which don't appear to be relevant to the latest master repo - should these be removed/updated?

[durack1]

Same goes for the tests directory, it appears to contain cdat tests which are replicated in the testing subdir?

[durack1]

Is the libcdms directory also obsolete - has this source migrated into the Packages subdir?

[aashish24]

• I think we should get rid of TODO.txt and update the Changes.txt.
• @doutriaux1 can we remove the tests directory?
• Yes, I think libcdms is moved under Packages..

[durack1]

The docs directory also contains a bunch of stuff that looks about 5+ years old.. The release notes nicely document some changes with cdat 4.3..!

[durack1]

I noted that a "release notes" link appeared (and has now disappeared) against the 2.0.0 tag under the releases page - is there a way to get github to autogenerate this from commits?

[durack1]

@doutriaux1 @aashish24 can you mark this as a 2.2 milestone please?

[durack1]

As noted in PCMDI/pcmdi_metrics#161 here is a more specific listing of files/dirs to cleanup:

• Cleanup deprecated subdirs/files during install: bin/{.gif, .ttf, .png, .scr, .xmb}, bin/images, bin/tutorials, include, man, share/man

[durack1]

@doutriaux1 you should probably push this to a 2.3 milestone..

[durack1]

This issue is related to #1353 - @doutriaux1 will need to complete the merging of images and resources subdirs and their install locations..

[durack1]

@doutriaux1 @aashish24 it seems my PR #1341 was closed, so this should no longer be a 2.4.0 milestone - I've amended this to 3.0 it would be nice to get this cleanup underway..

[doutriaux1]

@durack1 I will produce a fresh new PR when I do this.

[durack1]

@doutriaux1 2.6 would be a good time to get this cleanup complete..

[doutriaux1]

I think this is irrelevent with conda

[durack1]

@doutriaux1 I don't.. if it's dead, then kill it and clean things up so that redundant and many year old rubbish isn't polluting a clean repo..

[doutriaux1]

@durack1 it's kind of my point when I switch to the conda build, all this is going to didsappear from the repo

[durack1]

@doutriaux1 that is the conda variants.. But not the source, by which some folks will still persistently try to build from..

[aashish24]

I agree with @durack1. Build system and this issue is orthogonal things. In my rst_docs branch I took care of the docs folder but we still lot of files un-used and not maintained. I strongly suggest we remove them or update them.

[durack1]

@doutriaux1 @aashish24 FYI there is a closed PR that I submitted many moons ago (a year ago) #1341 - it was closed without merging

[doutriaux1]

@aashish24 when updating fully to conda that will imply doing the cleaning. No worries. Should be done before 2.6, which is when we officially switch to conda for releasing.

[aashish24]

@doutriaux1 I think we are mixing issues here. Conda or not conda should be a different issue. We should not solve every problem with one bullet 😄. These two issues are orthogonal and it would be better if we have two separate PR's for them.

[doutriaux1]

not really, lots of these files are not necessary really but are used by the insane install.py.in that will go away with conda build.

[durack1]

@doutriaux1 @aashish24 I see overlap with these standing issues:
#788 - this issue
#1353 - Merge contents of images and resources subdirs (this is closed, but shouldn't really be)
#1354 - Update license/legal info

[durack1]

@doutriaux1 you have sorted this by migrating to conda, closing