Updated meta_from_soup_row to handle parsing names with two commas #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue BurntSushi/nfldb#214. Added a max-split parameter to the string's split function so that player names are split once.
This solves the issue of unpacking the parts of a name, but now technically the player names in the database will be kind of weird, since the player's suffix will be a part of the first name. See the name which causes the problem: Leno, Charles, Jr
Edit: Thought about the further fix on the train this morning and looked into what would happen when there is only one comma, like most player names contain. A name with one comma would cause a ValueError. For some reason I thought
suffix
would just come back as None if there wasn't a second comma.Potentially a further fix could be: