Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svwzioep notion 509 #551

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

beastoin
Copy link

@beastoin beastoin commented Aug 8, 2024

No description provided.

plugins/example/client.py Outdated Show resolved Hide resolved
plugins/example/main.py Outdated Show resolved Hide resolved
plugins/instructions/notion-crm-oauth/README.md Outdated Show resolved Hide resolved
plugins/instructions/notion-crm-oauth/README.md Outdated Show resolved Hide resolved
@josancamon19
Copy link
Contributor

Hi @beastoin this shouldn't be a new plugin. Please check the current plugins/example/auth/ folder in the repo.

There's an existing notion plugin, this should be a completion of that plugin.

@beastoin
Copy link
Author

beastoin commented Aug 8, 2024

(This should be in another folder inside example/oauth) ~ but the community-plugins.json file should be updated to point to this new endpoint.

Sorry, got what your point of view (think so). So we don't need to create new community plugins (community-plugins.json), just need to point the current to the new one (oauth), right ?


Hi @beastoin this shouldn't be a new plugin. Please check the current plugins/example/auth/ folder in the repo.

There's an existing notion plugin, this should be a completion of that plugin.

Hi @josancamon19,

Do you mean plugins/example/basic_auth/ :? Actually, I used the pattern of the current Notion plugin in plugins/example/basic_auth/, then added the OAuth method and a prefix (/notion/) for the new OAuth Notion to ensure it does not break the current implementation.

So, should I update directly to basic_auth next?

@beastoin
Copy link
Author

beastoin commented Aug 8, 2024

Hi Joan,

A new commit just came in. Basically, we now just need to maintain one Notion plugin in plugins/example/oauth. The APIs will look like this:

Screenshot 2024-08-08 at 16 46 36

Feel free to ask for changes if needed ~
Good day!

@beastoin
Copy link
Author

beastoin commented Aug 8, 2024

Forgot to mention @josancamon19 , in case you need to discuss via chat, feel free to ping me on Discord at @thinh

Hi Joan,

A new commit just came in. Basically, we now just need to maintain one Notion plugin in plugins/example/oauth. The APIs will look like this:
Screenshot 2024-08-08 at 16 46 36

Feel free to ask for changes if needed ~ Good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants