Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish notion integration plugin ($200) #509

Closed
josancamon19 opened this issue Aug 2, 2024 · 6 comments
Closed

Finish notion integration plugin ($200) #509

josancamon19 opened this issue Aug 2, 2024 · 6 comments
Assignees
Labels

Comments

@josancamon19
Copy link
Contributor

Is your feature request related to a problem? Please describe.
https://github.com/BasedHardware/Friend/blob/main/plugins/example/basic_auth/memory_created.py

The notion memory created plugin is super rusty and could be much better.

Describe the solution you'd like
The setup form + on completed page should be beautiful, and have some sort of Friend <> Notion Integration UI.

create_notion_row should validate the user created the proper table, and if not, return a message accordingly.

Instead of the user having to setup their own integration, this should be a notion oAuth page, so you need to create a notion application, and allow oauth.

The oauth is done from the links you put in the README.

(This should be in another folder inside example/oauth) ~ but the community-plugins.json file should be updated to point to this new endpoint.

@josancamon19 josancamon19 changed the title Finish notion integration plugin Finish notion integration plugin ($200) Aug 2, 2024
@beastoin
Copy link
Collaborator

beastoin commented Aug 8, 2024

Thinh's change logs

  1. Notion OAuth is now ready
  1. What/s next?

    • ✅ Notion OAuth
    • ☑️ Validate for create_notion_row function.
    • ☑️ Dir example/oauth, communition-plugins.json

A PR will be sent after all tasks are done, or this task needs to be split into smaller parts.

Good day ~

@beastoin
Copy link
Collaborator

beastoin commented Aug 8, 2024

Thinh's change logs

  1. Done for the rests, please take a look at PR Svwzioep notion 509 #551

  2. What/s next?

    • ✅ Notion OAuth
    • ✅ Validate for create_notion_row function.
    • ✅ Dir example/oauth, communition-plugins.json
    • ☑️ Fix review / feedback

Good day ~

@josancamon19
Copy link
Contributor Author

Will review the PR and give feedback soon!

@beastoin
Copy link
Collaborator

beastoin commented Aug 8, 2024

Thank you @josancamon19

@beastoin
Copy link
Collaborator

Thinh's change logs

  1. PR merged Svwzioep notion 509 #551

  2. What/s next?

    • ✅ Notion OAuth
    • ✅ Validate for create_notion_row function.
    • ✅ Dir example/oauth, communition-plugins.json
    • ✅ Fix review / feedback

Cheers !!!

@beastoin
Copy link
Collaborator

Thanks!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants