Avoid unnecessary visit* method calls

src/Bicep.Core.IntegrationTests/ParserTests.cs

@@ -145,7 +145,7 @@ private static string GetSyntaxLoggingString(
  };
  }
 
- private sealed class SpanConsistencyVisitor : SyntaxVisitor
+ private sealed class SpanConsistencyVisitor : CstVisitor
  {
  private int maxPosition = 0;
 

src/Bicep.Core.UnitTests/Parsing/ExpressionTestVisitor.cs

@@ -6,7 +6,7 @@
 
 namespace Bicep.Core.UnitTests.Parsing
 {
- public sealed class ExpressionTestVisitor : SyntaxVisitor
+ public sealed class ExpressionTestVisitor : CstVisitor
  {
  private readonly StringBuilder buffer;
 

src/Bicep.Core.UnitTests/Syntax/SyntaxCollectorVisitor.cs

@@ -6,7 +6,7 @@
 
 namespace Bicep.Core.UnitTests.Syntax
 {
- public class SyntaxCollectorVisitor : SyntaxVisitor
+ public class SyntaxCollectorVisitor : CstVisitor
  {
  public record SyntaxItem(SyntaxBase Syntax, SyntaxItem? Parent, int Depth)
  {

src/Bicep.Core/Analyzers/Linter/Common/FindPossibleSecretsVisitor.cs

@@ -10,7 +10,7 @@
 
 namespace Bicep.Core.Analyzers.Linter.Common
 {
- public sealed class FindPossibleSecretsVisitor : SyntaxVisitor
+ public sealed class FindPossibleSecretsVisitor : AstVisitor
  {
  // TODO: Refactor to not use visitor
 

src/Bicep.Core/Analyzers/Linter/Rules/AdminUsernameShouldNotBeLiteralRule.cs

@@ -33,7 +33,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return visitor.diagnostics;
  }
 
- private class ResourceVisitor : SyntaxVisitor
+ private class ResourceVisitor : AstVisitor
  {
  public List<IDiagnostic> diagnostics = new();
 
@@ -57,7 +57,7 @@ public override void VisitResourceDeclarationSyntax(ResourceDeclarationSyntax sy
  }
  }
 
- private class PropertiesVisitor : SyntaxVisitor
+ private class PropertiesVisitor : AstVisitor
  {
  private readonly List<IDiagnostic> diagnostics;
 

src/Bicep.Core/Analyzers/Linter/Rules/ExplicitValuesForLocationParamsRule.cs

@@ -33,7 +33,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return visitor.diagnostics;
  }
 
- private sealed class Visitor : SyntaxVisitor
+ private sealed class Visitor : AstVisitor
  {
  public List<IDiagnostic> diagnostics = new();
 

src/Bicep.Core/Analyzers/Linter/Rules/LocationRuleBase.cs

@@ -282,7 +282,7 @@ bool onlyParamsWithDefaultValues
  return result.ToImmutableArray();
  }
 
- private class GetParametersUsedInResourceLocationsVisitor : SyntaxVisitor
+ private class GetParametersUsedInResourceLocationsVisitor : AstVisitor
  {
  private readonly SemanticModel semanticModel;
 
@@ -309,7 +309,7 @@ public override void VisitResourceDeclarationSyntax(ResourceDeclarationSyntax sy
  }
  }
 
- private class GetReferencedParametersVisitor : SyntaxVisitor
+ private class GetReferencedParametersVisitor : AstVisitor
  {
  private readonly SemanticModel semanticModel;
 
@@ -331,7 +331,7 @@ public override void VisitVariableAccessSyntax(VariableAccessSyntax syntax)
  }
  }
 
- private class ContainsCallToRgOrDeploymentLocationVisitor : SyntaxVisitor
+ private class ContainsCallToRgOrDeploymentLocationVisitor : AstVisitor
  {
  public string? ActualExpression;
 

src/Bicep.Core/Analyzers/Linter/Rules/NoHardcodedEnvironmentUrlsRule.cs

@@ -90,7 +90,7 @@ static bool hasLeadingOrTrailingAlphaNumericChar(string srcText, string hostname
  }
  }
 
- private sealed class Visitor : SyntaxVisitor
+ private sealed class Visitor : AstVisitor
  {
  public readonly Dictionary<TextSpan, string> DisallowedHostSpans = new();
  private readonly ImmutableArray<string> disallowedHosts;

src/Bicep.Core/Analyzers/Linter/Rules/NoHardcodedLocationRule.cs

@@ -156,7 +156,7 @@ private void ValidateResourceLocationValue(List<IDiagnostic> diagnostics, HashSe
  }
  }
 
- private sealed class RuleVisitor : SyntaxVisitor
+ private sealed class RuleVisitor : AstVisitor
  {
  public List<IDiagnostic> diagnostics = new();
  private readonly HashSet<VariableSymbol> variablesToChangeToParam = new();

src/Bicep.Core/Analyzers/Linter/Rules/NoLocationExprOutsideParamsRule.cs

@@ -32,7 +32,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return visitor.diagnostics;
  }
 
- private sealed class RuleVisitor : SyntaxVisitor
+ private sealed class RuleVisitor : AstVisitor
  {
  public List<IDiagnostic> diagnostics = new();
 

src/Bicep.Core/Analyzers/Linter/Rules/NoUnnecessaryDependsOnRule.cs

@@ -39,7 +39,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return visitor.diagnostics;
  }
 
- private class ResourceVisitor : SyntaxVisitor
+ private class ResourceVisitor : AstVisitor
  {
  public List<IDiagnostic> diagnostics = new();
 

src/Bicep.Core/Analyzers/Linter/Rules/OutputsShouldNotContainSecretsRule.cs

@@ -39,7 +39,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return visitor.diagnostics;
  }
 
- private class OutputVisitor : SyntaxVisitor
+ private class OutputVisitor : AstVisitor
  {
  public List<IDiagnostic> diagnostics = new();
 
@@ -70,7 +70,7 @@ public override void VisitOutputDeclarationSyntax(OutputDeclarationSyntax syntax
  }
  }
 
- private class OutputValueVisitor : SyntaxVisitor
+ private class OutputValueVisitor : AstVisitor
  {
  private readonly List<IDiagnostic> diagnostics;
 

src/Bicep.Core/Analyzers/Linter/Rules/PreferInterpolationRule.cs

@@ -31,7 +31,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return visitor.diagnostics;
  }
 
- private class Visitor : SyntaxVisitor
+ private class Visitor : AstVisitor
  {
  public List<IDiagnostic> diagnostics = new();
 

src/Bicep.Core/Analyzers/Linter/Rules/PreferUnquotedPropertyNamesRule.cs

@@ -33,7 +33,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return spanFixes.Select(kvp => CreateFixableDiagnosticForSpan(diagnosticLevel, kvp.Key, kvp.Value));
  }
 
- private sealed class Visitor : SyntaxVisitor
+ private sealed class Visitor : AstVisitor
  {
  private readonly Dictionary<TextSpan, CodeFix> spanFixes;
 

src/Bicep.Core/Analyzers/Linter/Rules/SecureParameterDefaultRule.cs

@@ -55,7 +55,7 @@ override public IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  }
  }
 
- private class NewGuidVisitor : SyntaxVisitor
+ private class NewGuidVisitor : AstVisitor
  {
  public bool hasNewGuid = false;
 

src/Bicep.Core/Analyzers/Linter/Rules/SimplifyInterpolationRule.cs

@@ -33,7 +33,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  return spanFixes.Select(kvp => CreateFixableDiagnosticForSpan(diagnosticLevel, kvp.Key, kvp.Value));
  }
 
- private sealed class Visitor : SyntaxVisitor
+ private sealed class Visitor : AstVisitor
  {
  private readonly Dictionary<TextSpan, CodeFix> spanFixes;
  private readonly SemanticModel model;

src/Bicep.Core/Analyzers/Linter/Rules/UseResourceIdFunctionsRule.cs

@@ -162,7 +162,7 @@ public override string FormatMessage(params object[] values)
  return pathMessage is null ? mainMessage : $"{mainMessage} {pathMessage}";
  }
 
- private class IdPropertyVisitor : SyntaxVisitor
+ private class IdPropertyVisitor : AstVisitor
  {
  private readonly List<Failure> failures = new();
  public IEnumerable<Failure> Failures => failures;

src/Bicep.Core/Analyzers/Linter/Rules/UseStableResourceIdentifiersRule.cs

@@ -43,7 +43,7 @@ public override IEnumerable<IDiagnostic> AnalyzeInternal(SemanticModel model, Di
  public override string FormatMessage(params object[] values)
  => string.Format(CoreResources.UseStableResourceIdentifiersMessageFormat, values);
 
- private class Visitor : SyntaxVisitor
+ private class Visitor : AstVisitor
  {
  private static readonly IReadOnlySet<string> NonDeterministicFunctionNames = new HashSet<string>
  {

src/Bicep.Core/DataFlow/LocalSymbolDependencyVisitor.cs

@@ -8,7 +8,7 @@
 
 namespace Bicep.Core.DataFlow
 {
- public sealed class LocalSymbolDependencyVisitor : SyntaxVisitor
+ public sealed class LocalSymbolDependencyVisitor : AstVisitor
  {
  private readonly SemanticModel semanticModel;
 

src/Bicep.Core/Diagnostics/DisabledDiagnosticsCache.cs

@@ -5,6 +5,7 @@
 using System.Collections.Immutable;
 using System.Linq;
 using Bicep.Core.Extensions;
+using Bicep.Core.Parsing;
 using Bicep.Core.Syntax;
 using Bicep.Core.Text;
 
@@ -37,10 +38,11 @@ public ImmutableDictionary<int, DisableNextLineDirectiveEndPositionAndCodes> Get
  return visitor.GetDisableNextLineDiagnosticDirectivesCache();
  }
 
- private class SyntaxTriviaVisitor : SyntaxVisitor
+ private class SyntaxTriviaVisitor : CstVisitor
  {
- private ImmutableArray<int> lineStarts;
- private ImmutableDictionary<int, DisableNextLineDirectiveEndPositionAndCodes>.Builder disableNextLineDiagnosticDirectivesCacheBuilder = ImmutableDictionary.CreateBuilder<int, DisableNextLineDirectiveEndPositionAndCodes>();
+ private readonly ImmutableArray<int> lineStarts;
+
+ private readonly ImmutableDictionary<int, DisableNextLineDirectiveEndPositionAndCodes>.Builder disableNextLineDiagnosticDirectivesCacheBuilder = ImmutableDictionary.CreateBuilder<int, DisableNextLineDirectiveEndPositionAndCodes>();
 
  public SyntaxTriviaVisitor(ImmutableArray<int> lineStarts)
  {

src/Bicep.Core/Emit/ForSyntaxValidatorVisitor.cs

@@ -8,7 +8,7 @@
 
 namespace Bicep.Core.Emit
 {
- public sealed class ForSyntaxValidatorVisitor : SyntaxVisitor
+ public sealed class ForSyntaxValidatorVisitor : AstVisitor
  {
  // we don't support nesting of property loops right now
  private const int MaximumNestedPropertyLoopCount = 1;

src/Bicep.Core/Emit/FunctionPlacementValidatorVisitor.cs

@@ -11,7 +11,7 @@
 
 namespace Bicep.Core.Emit
 {
- public class FunctionPlacementValidatorVisitor : SyntaxVisitor
+ public class FunctionPlacementValidatorVisitor : AstVisitor
  {
  private enum VisitedElement
  {

src/Bicep.Core/Emit/InlineDependencyVisitor.cs

@@ -11,7 +11,7 @@
 
 namespace Bicep.Core.Emit
 {
- public class InlineDependencyVisitor : SyntaxVisitor
+ public class InlineDependencyVisitor : AstVisitor
  {
  private enum Decision
  {

src/Bicep.Core/Emit/IntegerValidatorVisitor.cs

@@ -7,7 +7,7 @@
 
 namespace Bicep.Core.Emit
 {
- public class IntegerValidatorVisitor : SyntaxVisitor
+ public class IntegerValidatorVisitor : AstVisitor
  {
  private readonly IDiagnosticWriter diagnosticWriter;
  private readonly SemanticModel semanticModel;

src/Bicep.Core/Emit/ResourceDependencyVisitor.cs

@@ -13,7 +13,7 @@
 
 namespace Bicep.Core.Emit
 {
- public class ResourceDependencyVisitor : SyntaxVisitor
+ public class ResourceDependencyVisitor : AstVisitor
  {
  private readonly SemanticModel model;
  private Options? options;

src/Bicep.Core/Navigation/SyntaxBaseExtensions.cs

@@ -25,7 +25,7 @@ public static class SyntaxBaseExtensions
  return visitor.Result;
  }
 
- private sealed class NavigationSearchVisitor : SyntaxVisitor
+ private sealed class NavigationSearchVisitor : CstVisitor
  {
  private readonly int offset;
  private readonly Func<SyntaxBase, bool> predicate;
@@ -89,7 +89,7 @@ public static string ToTextPreserveFormatting(this SyntaxBase syntax)
  return sb.ToString();
  }
 
- private class PrintVisitor : SyntaxVisitor
+ private class PrintVisitor : CstVisitor
  {
  private readonly StringBuilder buffer;
 

src/Bicep.Core/Navigation/SyntaxTriviaExtensions.cs

@@ -21,7 +21,7 @@ public static class SyntaxTriviaExtensions
  return visitor.Result;
  }
 
- private sealed class NavigationSearchVisitor : SyntaxVisitor
+ private sealed class NavigationSearchVisitor : CstVisitor
  {
  private readonly int offset;
  private readonly Func<SyntaxTrivia, bool> predicate;

src/Bicep.Core/Parsing/ParseDiagnosticsVisitor.cs

@@ -11,7 +11,7 @@ namespace Bicep.Core.Parsing
  /// <summary>
  /// Visitor responsible for collecting all the parse diagnostics from the parse tree.
  /// </summary>
- public class ParseDiagnosticsVisitor : SyntaxVisitor
+ public class ParseDiagnosticsVisitor : CstVisitor
  {
  private readonly IDiagnosticWriter diagnosticWriter;
 

src/Bicep.Core/PrettyPrint/DocumentBuildVisitor.cs

@@ -12,7 +12,7 @@
 
 namespace Bicep.Core.PrettyPrint
 {
- public class DocumentBuildVisitor : SyntaxVisitor
+ public class DocumentBuildVisitor : CstVisitor
  {
  private static readonly ILinkedDocument Nil = new NilDocument();
 

src/Bicep.Core/Semantics/DeclarationVisitor.cs

@@ -16,7 +16,7 @@
 
 namespace Bicep.Core.Semantics
 {
- public sealed class DeclarationVisitor : SyntaxVisitor
+ public sealed class DeclarationVisitor : AstVisitor
  {
  private readonly INamespaceProvider namespaceProvider;
  private readonly IFeatureProvider features;

src/Bicep.Core/Semantics/NameBindingVisitor.cs

@@ -14,7 +14,7 @@
 
 namespace Bicep.Core.Semantics
 {
- public sealed class NameBindingVisitor : SyntaxVisitor
+ public sealed class NameBindingVisitor : AstVisitor
  {
  private FunctionFlags allowedFlags;
 

src/Bicep.Core/Semantics/ResourceAncestorVisitor.cs

@@ -8,7 +8,7 @@
 
 namespace Bicep.Core.Semantics
 {
- public sealed class ResourceAncestorVisitor : SyntaxVisitor
+ public sealed class ResourceAncestorVisitor : AstVisitor
  {
  private readonly SemanticModel semanticModel;
  private readonly ImmutableDictionary<DeclaredResourceMetadata, ResourceAncestor>.Builder ancestry;