Avoid unnecessary visit* method calls #9105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeskew
reviewed
Nov 23, 2022
shenglol
commented
Nov 23, 2022
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Runtime.CompilerServices; | ||
| using Bicep.Core.Parsing; | ||
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Bicep.Core.Syntax | ||
| { | ||
| public abstract class SyntaxVisitor : ISyntaxVisitor |
There was a problem hiding this comment.
With the changes to the base class, the ISyntaxVisitor interface may not be needed anymore. I'll send a follow up PR to replace references to ISyntaxVisitor with SyntaxVisitor.
jeskew
approved these changes
Nov 28, 2022
majastrz
reviewed
Nov 28, 2022
| namespace Bicep.Core.Syntax | ||
| { | ||
| /// <summary> | ||
| /// Visits an <see href="https://en.wikipedia.org/wiki/Abstract_syntax_tree">abstract syntax tree (AST)</see>. |
majastrz
reviewed
Nov 28, 2022
| @@ -48,7 +48,7 @@ public bool IsDescendant(SyntaxBase node, SyntaxBase potentialAncestor) | |||
| return false; | |||
| } | |||
|
|
|||
| private sealed class ParentTrackingVisitor : SyntaxVisitor | |||
| private sealed class ParentTrackingVisitor : AstVisitor | |||
There was a problem hiding this comment.
The original intent of SyntaxHierarchy was to create parent pointers for all the nodes in the CST. Given that all the tests are passing with the change, we are clearly only calculating parents for AST nodes. Worth adding a comment somewhere to indicate that we only create the hierarchy for AST nodes?
majastrz
approved these changes
Nov 28, 2022
anthony-c-martin
approved these changes
Nov 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another quick and easy optimization. The current
SyntaxVisitoris a concrete syntax tree (CST) / parse tree visitor which visits every single syntax tree node, but in most cases, this is not necessary. The PR splitsSyntaxVisitorinto anAstVisitorfor traversing the AST (which doesn't include tokens such as keywords and brackets) and aCstVisitorfor visiting the CST. Visitors that need to access all syntax nodes, such asDocumentBuildVisitor,ParseDiagnosticsVisitor, etc., are inherited fromCstVisitor. Other visitors are inherited fromAstVisitor.Closes #7403.
Benchmarks
CstVisitorvs.AstVisitorCompilation
Before
After
Microsoft Reviewers: Open in CodeFlow