Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ApiVersionComparer to sort Resource Types #1784

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

miqm
Copy link
Collaborator

@miqm miqm commented Mar 8, 2021

Fixes #737

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@miqm miqm force-pushed the feature/api-version-sorting-737 branch from 001fca6 to fc4cc60 Compare March 9, 2021 07:24
@majastrz majastrz merged commit 1ac5ae4 into Azure:main Mar 9, 2021
@miqm miqm deleted the feature/api-version-sorting-737 branch March 9, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource type completion sort order should account for API version suffixes
2 participants