Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource type completion sort order should account for API version suffixes #737

Closed
majastrz opened this issue Oct 27, 2020 · 2 comments · Fixed by #1784
Closed

Resource type completion sort order should account for API version suffixes #737

majastrz opened this issue Oct 27, 2020 · 2 comments · Fixed by #1784
Labels
enhancement New feature or request
Milestone

Comments

@majastrz
Copy link
Member

The resource type completions are currently sorted ascending by the fully qualified resource type and then descending by the API version. The API version component is sorted lexicographically, which can give priority to wrong suffixes.

We should implement a comparer that sorts resource types more accurately.

@majastrz majastrz added the enhancement New feature or request label Oct 27, 2020
@ghost ghost added the Needs: Triage 🔍 label Oct 27, 2020
@alex-frankel alex-frankel added this to the v0.3 milestone Oct 28, 2020
@alex-frankel alex-frankel added this to To Do in 0.3 release Nov 16, 2020
@miqm
Copy link
Collaborator

miqm commented Jan 25, 2021

I think that we have way too much completions provided and it's not very useful now. longer types (often child resources) are being cut in the middle, resulting that you still need to know the type you're looking for.

I'dlike to ssuggest changing completions from one list of type&api to segmented approach like in C# namespaces - you would get each type fqdn frament separately.

less robust approach is to separate completions of type and api - first choose type, then api version.

or perhaps a mix of those: when you have some part of the type alredy entered, in completion window just show remaining type part, not entire type (will avoid cutting long types)

@miqm
Copy link
Collaborator

miqm commented Jan 25, 2021

I just realised that I wrote similar idea in #1060.

one thing is api version sorting and second is type selection, so I'll move my idea there and leave this for the api sorting.

@alex-frankel alex-frankel removed this from To Do in 0.3 release Mar 8, 2021
@alex-frankel alex-frankel modified the milestones: v0.3, v0.4 Mar 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants