Check namespaces in prefer-interpolation linter rule #14050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-c-martin
commented
May 6, 2024
Comment on lines
+417
to
+420
| public void Codefix_ignores_nested_concats() => AssertCodeFix(""" | ||
| var test = conc|at('abc', concat('def', 'ghi'), 'jkl') | ||
| """, """ | ||
| var test = 'abc${concat('def', 'ghi')}jkl' |
There was a problem hiding this comment.
I removed the ability for this linter rule to recursively fix concat() - felt unnecessarily complex, unlikely to come up in the real world, and easy to handle if it does.
|
Test this change out locally with the following install scripts (Action run 8971963806) VSCode
Azure CLI
|
jeskew
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2773
Microsoft Reviewers: Open in CodeFlow