Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter does not understand namespaces #2773

Closed
StephenWeatherford opened this issue May 21, 2021 · 3 comments · Fixed by #14050
Closed

Linter does not understand namespaces #2773

StephenWeatherford opened this issue May 21, 2021 · 3 comments · Fixed by #14050
Labels
bug Something isn't working devdiv Related to Bicep tooling efforts in DevDiv story: linter

Comments

@StephenWeatherford
Copy link
Contributor

For this:

param p1 string = concat('a', 'b')

the linter suggests using interpolation instead of concat

But it gives no warning for this, which is equivalent:

param p1 string = sys.concat('a', 'b')

See comments from Marcin: #2341 (comment)

@StephenWeatherford
Copy link
Contributor Author

Recommend post-0.4 because:

  1. Seems to be an issue of false negatives, not false positives
  2. There are currently no overlaps between namespaces

@StephenWeatherford
Copy link
Contributor Author

Also affects checks against "newguid"

@StephenWeatherford
Copy link
Contributor Author

This is done correctly in some rules but needs to be made consistent and have better re-usable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devdiv Related to Bicep tooling efforts in DevDiv story: linter
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants