Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bicepparam files to reference BR, TS & JSON paths #11703

Merged
merged 6 commits into from
Sep 9, 2023
Merged

Allow bicepparam files to reference BR, TS & JSON paths #11703

merged 6 commits into from
Sep 9, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Sep 3, 2023 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023 •
edited
Loading

Test Results (win-x64)

       33 files  ±  0         33 suites  ±0   34m 42s ⏱️ - 5m 44s
10 458 tests +10  10 458 ✔️ +10  0 💤 ±0  0 ❌ ±0 
12 678 runs  +10  12 678 ✔️ +10  0 💤 ±0  0 ❌ ±0 

Results for commit ca1915f. ± Comparison against base commit 8378277.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023 •
edited
Loading

Test Results (linux-musl-x64)

       33 files  ±  0         33 suites  ±0   30m 21s ⏱️ - 2m 21s
10 446 tests +10  10 446 ✔️ +10  0 💤 ±0  0 ❌ ±0 
12 667 runs  +10  12 667 ✔️ +10  0 💤 ±0  0 ❌ ±0 

Results for commit ca1915f. ± Comparison against base commit 8378277.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023 •
edited
Loading

Test Results (osx-x64)

       33 files  ±  0         33 suites  ±0   1h 39m 31s ⏱️ + 9m 14s
10 450 tests +10  10 450 ✔️ +10  0 💤 ±0  0 ❌ ±0 
12 671 runs  +10  12 671 ✔️ +10  0 💤 ±0  0 ❌ ±0 

Results for commit ca1915f. ± Comparison against base commit 8378277.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023 •
edited
Loading

Test Results (linux-x64)

       33 files  ±  0         33 suites  ±0   40m 45s ⏱️ + 6m 19s
10 446 tests +10  10 446 ✔️ +10  0 💤 ±0  0 ❌ ±0 
12 667 runs  +10  12 667 ✔️ +10  0 💤 ±0  0 ❌ ±0 

Results for commit ca1915f. ± Comparison against base commit 8378277.

♻️ This comment has been updated with latest results.

jeskew
jeskew approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@jeskew jeskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but how is this feature expected to be used? If a user includes a using 'br:...' statement in a params file, would they need to build the params file, download the template, and deploy the pair in three separate steps?

@anthony-c-martin
Copy link
Member Author

LGTM, but how is this feature expected to be used? If a user includes a using 'br:...' statement in a params file, would they need to build the params file, download the template, and deploy the pair in three separate steps?

The build-params command takes care of all of those things, so from the perspective of the user it is just a single action. I've also submitted PRs for the AzCLI & AzPwsh repos (links in description) to make the "TemplateFile" param optional if the user is using a .bicepparam file - so the flow would look like:

  • User runs az deployment group create -g myRg --parameters main.bicepparam
  • AzCLI invokes bicep build-params main.bicepparam and outputs JSON to stdout containing the compiled parameters + template (or template spec id if using ts:) - example input and stdout output
  • AzCLI takes template + parameters and triggers deployment

@anthony-c-martin anthony-c-martin force-pushed the ant/bicepparm_reg branch 2 times, most recently from 9a84562 to 4f93d4b Compare September 8, 2023 18:08
@anthony-c-martin anthony-c-martin merged commit 6904c4a into main Sep 9, 2023
52 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/bicepparm_reg branch September 9, 2023 04:02
This was referenced Sep 12, 2023
Closed
Closed
@anthony-c-martin anthony-c-martin mentioned this pull request Oct 3, 2023
Merged
anthony-c-martin added a commit that referenced this pull request Oct 3, 2023
@anthony-c-martin
Show br & ts completions for using declarations (#12030)
db4b562 
Adds completions for #11703
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/12030)
@anthony-c-martin anthony-c-martin mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeskew jeskew jeskew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directly reference registery modules from .bicepparams
2 participants
@anthony-c-martin @jeskew