This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: #926 Escape servicePrincipalClientSecret in Windows custom script block #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run pr-e2e |
|
lgtm pending E2E |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xizha162
approved these changes
Apr 1, 2019
|
unit tests are failing @PatrickLang |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
==========================================
- Coverage 73.4% 73.35% -0.05%
==========================================
Files 130 130
Lines 17689 17717 +28
==========================================
+ Hits 12984 12996 +12
- Misses 4007 4024 +17
+ Partials 698 697 -1 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, PatrickLang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The AADClientSecret needs to be escaped in case it contains a special character such as
)Issue Fixed:
Fixes #926
Requirements:
Notes:
Not tested, relying on automation to test it