Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

Using special characters in client_secret will break windows node pool creation #926

Closed
xizha162 opened this issue Apr 1, 2019 · 1 comment · Fixed by #927 or #1174
Closed

Using special characters in client_secret will break windows node pool creation #926

xizha162 opened this issue Apr 1, 2019 · 1 comment · Fixed by #927 or #1174

Comments

@xizha162
Copy link
Contributor

xizha162 commented Apr 1, 2019

Is this a request for help?: No.

Is this an ISSUE or FEATURE REQUEST? (choose one): ISSUE

What version of aks-engine?: 1.12.6

Kubernetes version: 1.12.6

What happened: When the client secret includes special chars such as "(" and ")", the node provision will fail.

What you expected to happen: Node provision to succeed.

How to reproduce it (as minimally and precisely as possible): Provision a windows agent pool with specials chars ")" in the service principal client secret.

Anything else we need to know:
@welcome
Copy link

welcome bot commented Apr 1, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.

PatrickLang pushed a commit to PatrickLang/aks-engine that referenced this issue Apr 1, 2019
bug: fix Azure#926 Escape servicePrincipalClientSecret in Windows cus…
0d27f9a 
…tom script block
PatrickLang pushed a commit to PatrickLang/aks-engine that referenced this issue Apr 1, 2019
fix: Azure#926 Escape servicePrincipalClientSecret in Windows custom …
4beeab9 
…script block
@PatrickLang PatrickLang mentioned this issue Apr 1, 2019
Merged
4 tasks
acs-bot pushed a commit that referenced this issue Apr 3, 2019
@PatrickLang @acs-bot
fix: #926 Escape servicePrincipalClientSecret in Windows custom scrip…
8b82f15 
…t block (#927)

* fix: #926 Escape servicePrincipalClientSecret in Windows custom script block

* Fix unit test

* Fixing escapes
mboersma pushed a commit that referenced this issue Apr 4, 2019
@PatrickLang @mboersma
fix: #926 Escape servicePrincipalClientSecret in Windows custom scrip…
8b38c96 
…t block (#927)

* fix: #926 Escape servicePrincipalClientSecret in Windows custom script block

* Fix unit test

* Fixing escapes
@PatrickLang PatrickLang reopened this Apr 30, 2019
PatrickLang pushed a commit to PatrickLang/aks-engine that referenced this issue Apr 30, 2019
fix: Azure#926 - Base64 encode sp password
462b86d
@PatrickLang PatrickLang mentioned this issue Apr 30, 2019
Merged
4 tasks
jackfrancis pushed a commit that referenced this issue Apr 30, 2019
@PatrickLang @jackfrancis
fix: #926 - Base64 encode sp password (#1174)
55b12ea
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PatrickLang @xizha162