Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forbid wildcard in label filters #22

Merged
merged 2 commits into from
Nov 8, 2023
Merged

forbid wildcard in label filters #22

merged 2 commits into from
Nov 8, 2023

Conversation

Eskibear
Copy link
Member

@Eskibear Eskibear commented Nov 2, 2023

This PR:

  • forbid wildcards by throwing errors if * or , detected in label filters. (because we cannot handle settings with the same key but different labels"
  • update test utils and add corresponding test cases.

@Eskibear Eskibear mentioned this pull request Nov 8, 2023
Closed
@Eskibear Eskibear merged commit b4455bb into main Nov 8, 2023
5 checks passed
@Eskibear Eskibear deleted the wildcard branch November 8, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avanigupta avanigupta avanigupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eskibear @avanigupta