New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup exact same selectors while keep original precedence #23

Closed

Eskibear opened this issue Nov 8, 2023 · 0 comments · Fixed by #31

Member

Eskibear commented Nov 8, 2023

Dedup same selectors can save requests. And we should ensure the precedence of originally passed selectors unchanged.

selectors: [ 
            { keyFilter: "app.*", labelFilter: "dev" },
            { keyFilter: "app.*", labelFilter: "production" },
            { keyFilter: "app.*", labelFilter: "dev" },
]

Without dedup, it's clear that the last "app.* + dev" wins. After dedup, we should keep the same precedence, and in this case let "app.* + dev" win.

Originally posted by @Eskibear in #22 (comment)

Eskibear mentioned this issue

Dedup exact same selectors while keep original precedence #31

Merged

Eskibear closed this as completed in #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment