Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky specs: proposals, legislation and probe options Voting comments Update #1606

Merged
merged 2 commits into from
Oct 26, 2018
Merged

Fix flaky specs: proposals, legislation and probe options Voting comments Update #1606

merged 2 commits into from
Oct 26, 2018

Commits on Oct 23, 2018

  1. Make Capybara check the page between comment votes 

    As pointed out in PR consul#2734:

"After clicking the first link, there's an AJAX request which replaces
the existing `.in-favor a` and `.against a` links with new elements. So
if Capybara tries to click the existing `.against a` link at the same
moment it's being replaced, clicking the link won't generate a new
request".

Making Capybara check the page for new content before clicking the
second link solves the problem.

This commit solves issues afecting both Madrid's fork and the original
CONSUL repo.
    @javierm
    javierm committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    66914e6 View commit details
    Browse the repository at this point in the history

  2. Make Capybara check the page between custom votes 

    As pointed out in PR consul#2734:

"After clicking the first link, there's an AJAX request which replaces
the existing `.in-favor a` and `.against a` links with new elements. So
if Capybara tries to click the existing `.against a` link at the same
moment it's being replaced, clicking the link won't generate a new
request".

Making Capybara check the page for new content before clicking the
second link solves the problem.

This commit solves issues affecting Madrid's fork but not the original
CONSUL repo.
    @javierm
    javierm committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    8b8a191 View commit details
    Browse the repository at this point in the history