Fix flaky specs: proposals, legislation and probe options Voting comments Update #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
2734_consul_related-fix_flaky_comments_spec
branch
from
7cfbc1e
to
beea5f5
Compare
As pointed out in PR consul#2734: "After clicking the first link, there's an AJAX request which replaces the existing `.in-favor a` and `.against a` links with new elements. So if Capybara tries to click the existing `.against a` link at the same moment it's being replaced, clicking the link won't generate a new request". Making Capybara check the page for new content before clicking the second link solves the problem. This commit solves issues afecting both Madrid's fork and the original CONSUL repo.
As pointed out in PR consul#2734: "After clicking the first link, there's an AJAX request which replaces the existing `.in-favor a` and `.against a` links with new elements. So if Capybara tries to click the existing `.against a` link at the same moment it's being replaced, clicking the link won't generate a new request". Making Capybara check the page for new content before clicking the second link solves the problem. This commit solves issues affecting Madrid's fork but not the original CONSUL repo.
javierm
force-pushed
the
2734_consul_related-fix_flaky_comments_spec
branch
from
beea5f5
to
8b8a191
Compare
decabeza
approved these changes
Oct 23, 2018
voodoorai2000
approved these changes
Oct 25, 2018
This was referenced Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Fix the flaky specs that appeared in
spec/features/comments/proposals_spec.rb:463("Commenting proposals Voting comments Update"),spec/features/comments/legislation_questions_spec.rb:498and ("Commenting legislation questions Voting comments Update") andspec/features/custom/probe_option_comments_spec.rb:466("Commenting Probe Options Voting comments Update").Explain why the test is flaky, or under which conditions/scenario it fails randomly
As mentioned in consul#2734:
Here's the relevant part of the spec:
After clicking the first link, there's an AJAX request which replaces the existing .in-favor a and .against a links with new elements. So if Capybara tries to click the existing .against a link at the same moment it's being replaced, clicking the link won't generate a new request.
Explain why your PR fixes it
Making Capybara check the page for new content before clicking the second link solves the problem.
Does this PR need a Backport to CONSUL?
Yes, but only backport the first commit, since the second one changes code not present in the main CONSUL repo.