Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Signup: Handle the case where users block third-party cookies/data #13983

Merged
merged 14 commits into from
May 29, 2017
Merged

Social Signup: Handle the case where users block third-party cookies/data #13983

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a7ae224
Show a message when 3rd party cookies are disabled
pento May 12, 2017
6cdca3b
Social Signup: update copy when third-party cookies are blocked
fabianapsimoes May 12, 2017
1791649
Clean up the code a little bit.
pento May 15, 2017
a25780c
Tweak the copy.
pento May 15, 2017
8f37861
Add a disabled-style Google logo for when the Google button is disabled.
pento May 15, 2017
a5f8d5b
Reject the promise in case of a idpiframe_initialization_failed error
Tug May 15, 2017
acafb76
Sign up: Show Google service error block only when there is an error
gziolo May 15, 2017
e258338
Updated info text for social buttons.
pento May 16, 2017
b8c4049
Change the error message to a popover
pento May 18, 2017
e34bad4
Remove an unnecessary newline
pento May 18, 2017
46d8aa6
Always associate the Popover with the social button
pento May 23, 2017
111f090
Switch from `current()` to `currentTarget` to find the button when ho…
pento May 24, 2017
8084b81
Revert the form text changes from fc3acc4 and 4cf9438
pento May 24, 2017
8f0d8ba
When testing, the `Login` form must be loaded after `useFakeDom()`, b…
pento May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak the copy.
  • Loading branch information
@pento @drewblaisdell
pento authored and drewblaisdell committed May 24, 2017
commit a25780cd55c5e248068a4778fa3f0bb32c833dc8
6 changes: 2 additions & 4 deletions client/components/signup-form/social.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class SocialSignupForm extends Component {
return (
<div className="signup-form__social">
<p>
{ this.props.translate( 'Or create account using social profile:' ) }
{ this.props.translate( "Or create account using social profile. We'll never post without your permission." ) }
</p>

<div className="signup-form__social-buttons">
Expand All @@ -57,9 +57,7 @@ class SocialSignupForm extends Component {
</div>

<p>
{ this.props.translate(
"Connect to your existing social profile to get started faster. We'll never post without your permission."
) }
{ this.props.translate( 'Connect to your existing social profile to get started faster.' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞 17 existing translations will be lost with this change.

</p>
</div>
);
Expand Down
4 changes: 1 addition & 3 deletions client/components/social-buttons/google.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ class GoogleLoginButton extends Component {

if ( 'idpiframe_initialization_failed' === error.error ) {
// This error is caused by 3rd party cookies being blocked.
this.setState( { error: translate( 'Your privacy settings are blocking us from connecting to your Google account. ' +
'Please enable "third-party cookies" in your browser or operating system, or sign up with an email address instead.'
) } );
this.setState( { error: translate( 'Please enable "third-party cookies" to connect your Google account.' ) } );
return null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tug should we return rejected Promise in this case, too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I believe we can simply remove that return statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i removed the return null, the console shows a JS error:

Object {error: "idpiframe_initialization_failed", details: "Failed to read the 'localStorage' property from 'Window': Access is denied for this document."}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to show an error in the console here. if we want to hide it in a debug() call for instance, that should be done by calling catch on the promise returned by this.initialize().

}

Expand Down