Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Signup: Handle the case where users block third-party cookies/data #13983

Merged
merged 14 commits into from
May 29, 2017
Merged

Social Signup: Handle the case where users block third-party cookies/data #13983

merged 14 commits into from
May 29, 2017
+131 −27

Commits on May 24, 2017

  1. Show a message when 3rd party cookies are disabled

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    a7ae224 View commit details
    Browse the repository at this point in the history

  2. Social Signup: update copy when third-party cookies are blocked

    @fabianapsimoes @drewblaisdell
    fabianapsimoes authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    6cdca3b View commit details
    Browse the repository at this point in the history

  3. Clean up the code a little bit.

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    1791649 View commit details
    Browse the repository at this point in the history

  4. Tweak the copy.

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    a25780c View commit details
    Browse the repository at this point in the history

  5. Add a disabled-style Google logo for when the Google button is disabled.

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    8f37861 View commit details
    Browse the repository at this point in the history

  6. Reject the promise in case of a idpiframe_initialization_failed error

    @Tug @drewblaisdell
    Tug authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    a5f8d5b View commit details
    Browse the repository at this point in the history

  7. Sign up: Show Google service error block only when there is an error

    @gziolo @drewblaisdell
    gziolo authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    acafb76 View commit details
    Browse the repository at this point in the history

  8. Updated info text for social buttons.

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    e258338 View commit details
    Browse the repository at this point in the history

  9. Change the error message to a popover 

    The popover will only show when the button is hovered or clicked.
    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    b8c4049 View commit details
    Browse the repository at this point in the history

  10. Remove an unnecessary newline

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    e34bad4 View commit details
    Browse the repository at this point in the history

  11. Always associate the Popover with the social button

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    46d8aa6 View commit details
    Browse the repository at this point in the history

  12. Switch from current() to currentTarget to find the button when ho… 

    …vering
    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    111f090 View commit details
    Browse the repository at this point in the history

  13. Revert the form text changes from fc3acc4 and 4cf9438

    @pento @drewblaisdell
    pento authored and drewblaisdell committed May 24, 2017
    Configuration menu
    Copy the full SHA
    8084b81 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2017

  1. When testing, the Login form must be loaded after useFakeDom(), b… 

    …ecause reasons.
    @pento
    pento committed May 25, 2017
    Configuration menu
    Copy the full SHA
    8f0d8ba View commit details
    Browse the repository at this point in the history