VN: Add validation to initialization configuration commands #27437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lashVN
force-pushed
the
add-response-validation
branch
from
b2e41cf
to
67cb589
Compare
|
The last commit is purely cosmetic, it looked like styling was inconsistent so I ran clang-format on the files. I couldn't find the file recommended or used project-wide, so I took my best guess based on looking through the code and style guide. Let me know if these were incorrect |
|
These changes are built upon PR #27285 , so I expect the first few commits which are contained within this PR (and resultant diffs) will be removed when that is merged. If not, I'll remove them after merge. Otherwise, I've tested these changes for successful arming of a AP connected to a VN, so this should be ready for review. |
lashVN
force-pushed
the
add-response-validation
branch
from
67cb589
to
ec3c27a
Compare
Expands wait_register_response (and renames to send_command_blocking) to accept any arbitrary command, and uses the new method for all sent commands
…her than just active port This change prevents a commonly seen baudrate overflow error on the unused port. Also pause asynchronous communications during initial configuration.
Non-functional changes, purely cosmetic.
lashVN
force-pushed
the
add-response-validation
branch
from
0317a44
to
c6008c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all configuration commands sent to the VN unit are not validated for a response, leading to difficult-to-diagnose errors when a command doesn't go through or is rejected by the VN. All commands send to the unit (particularly setup commands) should have their acceptance confirmation checked before the driver begins to use the data.