Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logout): Small improvements #124

Merged
merged 2 commits into from
Jan 5, 2023
Merged

feat(logout): Small improvements #124

merged 2 commits into from
Jan 5, 2023

Conversation

krizzu
Copy link
Contributor

@krizzu krizzu commented Jan 5, 2023

📑 What does this PR do?

Addressing comments from #111

✅ Checklist

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@krizzu krizzu marked this pull request as ready for review January 5, 2023 12:55
crocsandcoffee
crocsandcoffee reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@crocsandcoffee crocsandcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up!

ui/root/src/commonMain/kotlin/social/androiddev/root/root/RootComponent.kt Outdated Show resolved Hide resolved
ui/root/src/commonMain/kotlin/social/androiddev/root/root/RootComponentViewModel.kt Outdated Show resolved Hide resolved
ui/root/src/commonMain/kotlin/social/androiddev/root/splash/SplashContent.kt Show resolved Hide resolved
ui/root/src/commonMain/kotlin/social/androiddev/root/root/RootComponentViewModel.kt Outdated Show resolved Hide resolved
@krizzu
Copy link
Contributor Author

krizzu commented Jan 5, 2023

@crocsandcoffee Thanks for checking it out!

crocsandcoffee
crocsandcoffee approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@crocsandcoffee crocsandcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but plz confirm that last comment about navigating to timeline. Look good otherwise 👍

ui/root/src/commonMain/kotlin/social/androiddev/root/splash/SplashContent.kt Show resolved Hide resolved
@crocsandcoffee crocsandcoffee merged commit 3a67ee6 into AndroidDev-social:main Jan 5, 2023
@krizzu krizzu deleted the logout-followup branch January 5, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crocsandcoffee crocsandcoffee crocsandcoffee approved these changes

@thebino thebino Awaiting requested review from thebino thebino is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krizzu @crocsandcoffee