feat(logout): Keep user signed in #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
commented
Dec 21, 2022
ui/root/src/commonMain/kotlin/social/androiddev/root/composables/RootContent.kt
Show resolved
Hide resolved
krizzu
commented
Dec 21, 2022
ui/root/src/commonMain/kotlin/social/androiddev/root/splash/DefaultSplashComponent.kt
Outdated
Show resolved
Hide resolved
krizzu
commented
Jan 3, 2023
...e/src/desktopMain/kotlin/social/androiddev/common/persistence/di/DesktopPersistenceModule.kt
Show resolved
Hide resolved
krizzu
commented
Jan 4, 2023
krizzu
commented
Jan 4, 2023
ui/root/src/commonMain/kotlin/social/androiddev/root/splash/SplashContent.kt
Show resolved
Hide resolved
thebino
approved these changes
Jan 4, 2023
...onMain/kotlin/social/androiddev/domain/authentication/repository/AuthenticationRepository.kt
Show resolved
Hide resolved
...ation/src/commonMain/kotlin/social/androiddev/domain/authentication/usecase/GetAuthStatus.kt
Show resolved
Hide resolved
ui/root/src/commonMain/kotlin/social/androiddev/root/root/RootComponentViewModel.kt
Show resolved
Hide resolved
Comment on lines
+38
to
+47
| private val _authState = MutableStateFlow<AuthStatus?>(null) | ||
| override val authState = _authState.asStateFlow() | ||
|
|
||
| init { | ||
| viewModelScope.launch { | ||
| getAuthStatus().collect { currentStatus -> | ||
| _authState.value = currentStatus | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
why not just inline?
override val authState = getAuthStatus().stateIn(scope, ...., null)
ui/root/src/commonMain/kotlin/social/androiddev/root/splash/SplashContent.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 What does this PR do?
As part of #107, navigate user to sign in flow once authenticated.
For now, the auth status does not redirect to Timeline (waiting for #107), otherwise we might get stuck.
Things done:
rootmodule, moved Splash tosplashmodule✅ Checklist
🧪 How can this PR been tested?
🧾 Tasks Remaining: (List of tasks remaining to be implemented)
🖼️ Screenshots (if applicable):