Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github actions: use safe.directory for actions invoking git #15270

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Github actions: use safe.directory for actions invoking git #15270

merged 2 commits into from
Apr 20, 2022

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Apr 19, 2022

Summary of changes

PRs from today started failing, with git error. I am creating this pull request to reproduce the error and attempt to fix it within this PR.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the do not merge label Apr 19, 2022
@0xc0170 0xc0170 force-pushed the fix-test-github-action-git-failure branch from c400ad6 to d46ef3e Compare April 19, 2022 15:59
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 19, 2022
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 19, 2022 16:00
@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 19, 2022

actions/checkout#766 - related

@0xc0170 0xc0170 force-pushed the fix-test-github-action-git-failure branch 3 times, most recently from 1a5f739 to e86965c Compare April 20, 2022 09:59
@0xc0170
github action: update checkout to v3
8a59067 
See actions/checkout#762
Our tests are failing as checkout is not working (no git repository found)
@0xc0170
github action: add git safe directory
ad15f0a 
Where we use git commands directly, we need to add safe directory. This is because
the recent git changes introduced, for details visit:
actions/checkout#766
@0xc0170 0xc0170 force-pushed the fix-test-github-action-git-failure branch from b455f9f to ad15f0a Compare April 20, 2022 10:18
@0xc0170 0xc0170 changed the title WIP: Testing Github actions failing with git error Github actions: use safe.directory for actions invoking git Apr 20, 2022
@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 20, 2022

CI started

@0xc0170 0xc0170 merged commit decc6d0 into ARMmbed:master Apr 20, 2022
@0xc0170 0xc0170 mentioned this pull request Apr 20, 2022
Merged
@mergify mergify bot removed the ready for merge label Apr 20, 2022
This was referenced Apr 20, 2022
Merged
Merged
Closed
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
jeromecoutant added a commit to ARMmbed/stm32customtargets that referenced this pull request Aug 16, 2022
@jeromecoutant
Github actions: use safe.directory
6986b89 
Ref: ARMmbed/mbed-os#15270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@saheerb saheerb saheerb approved these changes

Assignees
No one assigned
Labels
release-version: 6.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@0xc0170 @ciarmcom @adbridge @saheerb @mbedmain