Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32L0 : I2C2 was missing #15268

Merged
merged 1 commit into from
Apr 26, 2022
Merged

STM32L0 : I2C2 was missing #15268

merged 1 commit into from
Apr 26, 2022

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Fix #15266

After #14557, I2C2 was missing for STM32L0 in the clock source configuration.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant jeromecoutant mentioned this pull request Apr 19, 2022
Closed
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 19, 2022
@ciarmcom ciarmcom requested a review from a team April 19, 2022 13:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the coding style failure

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 19, 2022

Please fix the coding style failure

Reviewing, it looks like this is an error in Github action itself. I'll check

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2022

Github actions fix #15270 was merged, please rebase and it should be green

@mergify mergify bot dismissed 0xc0170’s stale review April 20, 2022 12:28

Pull request has been modified.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 25, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 25, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 2d652c9 into ARMmbed:master Apr 26, 2022
@mergify mergify bot removed the ready for merge label Apr 26, 2022
@jeromecoutant jeromecoutant deleted the PR_L0_I2C2 branch April 26, 2022 08:54
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: st release-version: 6.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nucleo-L073RZ I2C2 not defined - Unknown instance
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @mbedmain