Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable CM0P_SLEEP component for Cypress targets #15195

Merged
merged 2 commits into from
Dec 21, 2021

Conversation

ATmobica
Copy link
Contributor

Summary of changes

There is no option to build Cypress target without CM0P_SLEEP component. The CM0P_SLEEP libraries are always linked to the main Cypress targets.
I need this option to build an application with a bootloader for Cypress board or update an image. The bootloader contains a CM0P sleep component so the application does not need it. Without CM0 core code we can put the app in right place in the flash memory, sign and upload it to the device.
Using "target.components_remove": [ "CM0P_SLEEP" ] in mbed_app.json does not work if we do not exclude the CM0P_SLEEP component from Cypress targets.
With these changes, components_remove option works perfectly to get the application building without CM0P_SLEEP.

Related PRs: #15192

Impact of changes

Only Cypress targets building. If you want to remove CM0P_SLEEP component from the build add:
"target.components_remove": [ "CM0P_SLEEP" ]
to your application's mbed_app.json file.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 15, 2021
@ciarmcom ciarmcom requested review from pan- and a team December 15, 2021 21:00
@ciarmcom
Copy link
Member

@ATmobica, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team December 16, 2021 09:04
@mergify mergify bot added needs: CI and removed needs: review labels Dec 16, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 17, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 149c5b1 into ARMmbed:master Dec 21, 2021
@mergify mergify bot removed the ready for merge label Dec 21, 2021
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants