Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable WHD component for Cypress targets #15192

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

ATmobica
Copy link
Contributor

Summary of changes

There is no option to build Cypress target without WHD component. The WHD libraries are always linked to the main Cypress targets.
I need this option to build a bootloader for Cypress board, where only bare-metal is required. The WHD requires RTOS, etc.
Using "target.components_remove": [ "WHD" ] in mbed_app.json does not work if we do not exclude the WHD component from Cypress targets.
With these changes, components_remove option works perfectly to get the application building without WHD

Impact of changes

Only Cypress targets building. If you want to remove WHD component from the build add:
"target.components_remove": [ "WHD" ]
to your application's mbed_app.json file.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 10, 2021
@ciarmcom ciarmcom requested review from pan- and a team December 10, 2021 12:30
@ciarmcom
Copy link
Member

@ATmobica, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Dec 13, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 13, 2021

CI started

Copy link

@ifyall ifyall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mbed-ci
Copy link

mbed-ci commented Dec 13, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants