Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: unit-tests: Make drivers unittests only depend on headers it uses #14813

Merged
merged 2 commits into from
Jun 24, 2021
Merged

CMake: unit-tests: Make drivers unittests only depend on headers it uses #14813

merged 2 commits into from
Jun 24, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jun 22, 2021 •
edited
Loading

Summary of changes

Previously the drivers unit tests depended on mbed-headers, which
is a collection of all available headers in mbed-os and these changes make drivers unit test only depend on the headers it's using.

Impact of changes

None.

Migration actions required

None.

Documentation

To be updated

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@rajkan01
CMake: unit-tests: Pwmout & Watchdog: Remove trailing whitespace
10beeab
@rajkan01
CMake: unit-tests: Make drivers UNITTESTS only depend on headers it uses
9a4bdb8 
Previously the drivers unit tests depended on `mbed-headers`, which
is a collection of all available headers in mbed-os. To make it easier
to separate the library, only depend on the headers we're using.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 22, 2021
@ciarmcom ciarmcom requested a review from a team June 22, 2021 11:30
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 22, 2021
LDong-Arm
LDong-Arm reviewed Jun 23, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be part of #14786?

@rajkan01
Copy link
Contributor Author

rajkan01 commented Jun 23, 2021 •
edited
Loading

Maybe this can be part of #14786?

Initially, I made these changes as part of #14786 but had a chat with Jaeden and decided to keep them as separate PR because this change is not relevant to moving a stub and make drivers unit test only depend on the headers it's using.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 23, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jun 24, 2021
@mbed-ci
Copy link

mbed-ci commented Jun 24, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@0xc0170 0xc0170 merged commit 28cdb37 into master Jun 24, 2021
@mergify mergify bot removed the ready for merge label Jun 24, 2021
@Patater Patater added this to In progress (8) in Mbed Core via automation Jun 25, 2021
@Patater Patater moved this from In progress (8) to Done in Mbed Core Jun 25, 2021
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
@0xc0170 0xc0170 deleted the drivers_unittest_header_lib branch October 5, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
component: core component: hal release-version: 6.13.0
Projects
No open projects
Mbed Core
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajkan01 @ciarmcom @mbed-ci @0xc0170 @LDong-Arm @mbedmain