Move mbed-stubs-drivers to the drivers directory #14786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkan01
changed the title
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
ciarmcom
added
needs: review
component: core
component: hal
component: test
stale
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions. |
Move the drivers stub library into the drivers component directory. so we can avoid duplicating the mbed-os source tree in a central UNITTESTS folder.
Move the header-only mbed-headers-drivers library the unit test stubs depend on into the drivers component directory. This makes the drivers stubs more self-contained and improves the composition of the library.
Previously the drivers stub library depended on `mbed-headers`, which is a collection of all available headers in mbed-os. To make it easier to separate the library, only depend on the headers we're using.
rajkan01
force-pushed
the
move_drivers_stub
branch
from
93cf853
to
e64d1c7
Compare
Mbed Core
automation
moved this from Review in progress (4)
to Reviewer approved & awaiting CI & merge (3)
Jun 23, 2021
0xc0170
approved these changes
Jun 24, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.13.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #14796
This PR makes the
mbed-stubs-driverslibrary more self-contained by removing the dependencies on the monolithic header libraries we created to make implementing the stubs easier. We also move the files to thedriversdirectory so the stubs live with the associated component.And the
mbed-stubs-driverslibrary andunit testsshould only depend on the headers it uses.Impact of changes
None
Migration actions required
None
Documentation
To be updated
Pull request type
Test results
Reviewers