Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix for custom_int's in feeder gateway #335

Merged
merged 4 commits into from
Nov 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion starknet_devnet/blueprints/feeder_gateway.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,18 @@ def validate_request(data: bytes, cls):
) from err


def validate_int(request_args: MultiDict, attribute: str):
"""Validate if attribute is int."""
try:
return int(request_args.get(attribute))
except (ValueError) as err:
raise StarknetDevnetException(
code=StarkErrorCode.MALFORMED_REQUEST,
message=str(err),
status_code=400,
) from err


def _check_block_hash(request_args: MultiDict):
block_hash = request_args.get("blockHash", type=custom_int)
if block_hash is not None:
Expand Down Expand Up @@ -186,7 +198,7 @@ async def get_storage_at():
_check_block_hash(request.args)

contract_address = request.args.get("contractAddress", type=custom_int)
key = request.args.get("key", type=custom_int)
key = validate_int(request.args, "key")

storage = await state.starknet_wrapper.get_storage_at(contract_address, key)
return jsonify(storage)
Expand Down
4 changes: 2 additions & 2 deletions test/rpc/test_rpc_transactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def test_add_invoke_transaction():
storage = gateway_call(
"get_storage_at",
contractAddress=contract_address,
key=hex(get_storage_var_address("balance")),
key=get_storage_var_address("balance"),
)

assert set(receipt.keys()) == {"transaction_hash"}
Expand Down Expand Up @@ -419,7 +419,7 @@ def test_add_invoke_transaction_v0():
storage = gateway_call(
"get_storage_at",
contractAddress=contract_address,
key=hex(get_storage_var_address("balance")),
key=get_storage_var_address("balance"),
)

assert set(receipt.keys()) == {"transaction_hash"}
Expand Down