Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Fix for custom_int's in feeder gateway #335

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Fix for custom_int's in feeder gateway #335

merged 4 commits into from
Nov 8, 2022

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Nov 4, 2022

Usage related changes

  • Unification of get_storage_at in feeder gateway to be the same as alpha-goerli

Development related changes

  • validate_int function added in feeder gateway

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing

@mikiw mikiw linked an issue Nov 4, 2022 that may be closed by this pull request
2 tasks
@mikiw mikiw changed the title Update feeder_gateway.py Fix for custom_int in feeder gateway Nov 4, 2022
@mikiw mikiw changed the title Fix for custom_int in feeder gateway Fix for custom_int's in feeder gateway Nov 4, 2022
@mikiw
Copy link
Contributor Author

mikiw commented Nov 4, 2022

Need to fix tests...

@mikiw
Copy link
Contributor Author

mikiw commented Nov 7, 2022

apparently get block can accept strings, for example: https://alpha4.starknet.io/feeder_gateway/get_block?blockNumber=pending

same with get_state_update and get_block_traces

@mikiw mikiw requested a review from FabijanC November 8, 2022 08:03
@FabijanC FabijanC merged commit 4b0522b into master Nov 8, 2022
@FabijanC FabijanC deleted the feeder-gateway branch November 8, 2022 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_storage_at accepts key as hex
2 participants