Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bundle of patmat issues #21000

Merged
merged 11 commits into from
Aug 5, 2024
Merged

Fix a bundle of patmat issues #21000

merged 11 commits into from
Aug 5, 2024

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Jul 3, 2024

Some of the issues are legitimate.

Fixes #20121
Fixes #20122
Fixes #20123

Fixes #20128
Fixes #20129
Fixes #20130
Fixes #20131
Fixes #20132

@dwijnand dwijnand force-pushed the patmat-issues branch 2 times, most recently from 2ed2826 to a2f7ecf Compare July 5, 2024 15:37
@dwijnand dwijnand marked this pull request as ready for review July 8, 2024 12:22
EugeneFlesselle
EugeneFlesselle reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@EugeneFlesselle EugeneFlesselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that familiar with the SpaceEngine so I could be missing things, but overall looks fine

There's mainly the explicit nulls which look like might be silenced too much

compiler/src/dotty/tools/dotc/config/Settings.scala Outdated Show resolved Hide resolved
compiler/src/dotty/tools/dotc/transform/patmat/Space.scala Show resolved Hide resolved
tests/warn/i20132.stream-Tuple2.scala Show resolved Hide resolved
@dwijnand dwijnand merged commit 976133a into scala:main Aug 5, 2024
28 checks passed
@dwijnand dwijnand deleted the patmat-issues branch August 5, 2024 21:29
@WojciechMazur WojciechMazur mentioned this pull request Aug 28, 2024
Merged
WojciechMazur added a commit that referenced this pull request Aug 28, 2024
@WojciechMazur
Backport "Fix a bundle of patmat issues" to 3.5.2 (#21478)
0492a30 
Backports #21000 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
This was referenced Sep 5, 2024
Merged
Merged
WojciechMazur added a commit that referenced this pull request Sep 6, 2024
@WojciechMazur
Backport "Fix a bundle of patmat issues" to 3.3.4 (#21549)
1a5bff6 
Backports #21000 and #21532 to 3.3.4-RC2. Fixes regression introduced in
RC1
@WojciechMazur WojciechMazur mentioned this pull request Sep 10, 2024
Merged
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
WojciechMazur added a commit to WojciechMazur/dotty that referenced this pull request Oct 9, 2024
@WojciechMazur
Revert "Fix a bundle of patmat issues"
1ed81d6 
This reverts PR scala#21000 due to introduced performance regression
@WojciechMazur WojciechMazur mentioned this pull request Oct 9, 2024
Merged
WojciechMazur added a commit to WojciechMazur/dotty that referenced this pull request Oct 9, 2024
@WojciechMazur
Revert "Fix a bundle of patmat issues"
cc2f6e9 
This reverts PR scala#21000 due to introduced performance regression
@WojciechMazur WojciechMazur mentioned this pull request Oct 9, 2024
Closed
WojciechMazur added a commit that referenced this pull request Oct 9, 2024
@WojciechMazur
Revert "Fix a bundle of patmat issues"
ebf5ae1 
This reverts PR #21000 due to introduced performance regression
WojciechMazur added a commit to VirtusLab/community-build3 that referenced this pull request Oct 9, 2024
@WojciechMazur
Workaround compilation performance regressions due to scala/scala3#21000
48fec8e 
 by disabling pattern match analysis in both affected projects in the code generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue left review comments

@EugeneFlesselle EugeneFlesselle EugeneFlesselle left review comments

Assignees

@EugeneFlesselle EugeneFlesselle

Labels
None yet
Projects
None yet
Milestone
3.6.0