Backport "Fix a bundle of patmat issues" to 3.5.2 #21478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Cherry-picked 4f22672]
[Cherry-picked 3ba51a6]
Some of the issues are legitimate [Cherry-picked b56da91]
[Cherry-picked 7183bb2]
[Cherry-picked 8df91fa]
Previously `defn.ListType.appliedTo(elemTp) <:< pat.tpe` failed when pat.tpe is something like ParamClause, an alias. [Cherry-picked e160de7]
Without that, we end up with either a flexible type or a `| Null`. [Cherry-picked 5fd810e]
[Cherry-picked 4dd8e8a]
[Cherry-picked 5b425ee]
[Cherry-picked ab240f1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #21000 to the 3.5.2 branch.
PR submitted by the release tooling.
[skip ci]