Uploaded image for project: 'Maven Shade Plugin'
  1. Maven Shade Plugin
  2. MSHADE-413

Maven shade plugin enters endless loop

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 3.2.4
    • 3.4.1
    • None

    Description

      Two issues at play here:

      • ShadeMojo.createDependencyReducedPom() pulls in origDeps = project.getDependencies() and later modifies these Dependency objects.
      • ShadeMojo.updateExcludesInDeps() enters it's own endless loop, endlessly adding the exact same exclusions.

      This leads to a reproducible endless loop (see below).

      If the Shade plugin's not using the Dependency objects "owned by Maven itself" (by setting promoteTransitiveDependencies to true), the build passes fine.

      I think, modifying the Dependency objects "owned by Maven itself" is bad for two reasons (which IMO justify the increased priority of this ticket):

      1. the reproducible endless loop
      2. it breaks the correctness of the project build - at least plugins running after the shade goal that use those dependencies.

      Attachments

        Issue Links

          Activity

            People

              gnodet Guillaume Nodet
              snazy Robert Stupp
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: