Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do correct cursor right with storing visual X in CursorRight action #3103

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Dec 27, 2023

The description was provided by @vicencb:

Here is a concrete example to reproduce the issue i am referring to:

Given this text file:

1234
ABCD
EFGH
IJKL

Move the cursor to 1 if not already there, then SelectDown, then CursorRight and finally CursorDown.
After this, the cursor is expected to be at E but instead it is after the H.

@vicencb
Copy link

vicencb commented Dec 27, 2023

I've just tested it: the issue is fixed.
As this issue matched the description of #3055 i tried to avoid creating a duplicate.
Are those the same or not?

@dustdfg
Copy link
Contributor Author

dustdfg commented Dec 28, 2023

I've just tested it: the issue is fixed. As this issue matched the description of #3055 i tried to avoid creating a duplicate. Are those the same or not?

No the #3055 is about the fact that when you select with mouse the start and end pointers aren't swapped when it is necessary. See new comment in that issue

@zyedidia zyedidia merged commit 4e383dd into zyedidia:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants