fix(config): expand home in GitHub token file read and use token for rate #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes three issues I found while testing the new GitHub token reading from files:
~/
home directory shortcut was not expanded, for example in@~/secrets/github-token
.--rate
option, the GitHub token stored in a config file was not used.For the second point I used
strings.TrimRight()
, which strips any of the\r\n
runes. Therefore, the trimming works properly for all OS line-ending styles (Unix, Mac, Windows).To fix the third point, I had to separate the loading of global options from project options into two different functions so the global options can be loaded earlier for the
--rate
option to have a populated GitHub token from a config file.