Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): display target when no upgrade is available #87

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

hhromic
Copy link
Contributor

@hhromic hhromic commented Oct 21, 2023

Here is another small UX improvement.
When there is no upgrade available for a target, eget does not report which target it is.
While this is redundant for a single target, it becomes confusing when using the -D, --download-all option.

For a configuration file with multiple targets configured, without this PR:

$ eget --download-all
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version
requested release is not more recent than current version

And with this PR applied:

$ eget --download-all
jqlang/jq: requested release is not more recent than current version
koalaman/shellcheck: requested release is not more recent than current version
hadolint/hadolint: requested release is not more recent than current version
zyedidia/eget: requested release is not more recent than current version
zyedidia/micro: requested release is not more recent than current version
golangci/golangci-lint: requested release is not more recent than current version
carvel-dev/ytt: requested release is not more recent than current version
go-task/task: requested release is not more recent than current version
goreleaser/goreleaser: requested release is not more recent than current version
mikefarah/yq: requested release is not more recent than current version
vectordotdev/vector: requested release is not more recent than current version

@zyedidia zyedidia merged commit 51b6852 into zyedidia:master Oct 21, 2023
@hhromic hhromic deleted the feat-show-target-noupgrade branch October 21, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants