Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for musl-based Releases #105

Closed
commiyou opened this issue Jul 6, 2024 · 7 comments
Closed

Support for musl-based Releases #105

commiyou opened this issue Jul 6, 2024 · 7 comments

Comments

@commiyou
Copy link

commiyou commented Jul 6, 2024

I am working on a CentOS 6.3 server, and the system’s built-in glibc doesn’t support GLIBC_2.34. So, is there a musl version of eget that can be released?

@zyedidia
Copy link
Owner

zyedidia commented Jul 7, 2024

Could you elaborate on what you mean?

@benjaminbauer
Copy link

benjaminbauer commented Jul 7, 2024

I guess the OP is referring to cases where binaries are provided for glibc and musl systems. e.g. https://github.com/sharkdp/fd/releases/tag/v10.1.0

When I eget sharkdp/fd, I have to chose if I want the musl or glibc version.

It would be cool, if eget could figure out on what kind of system it runs and pick accordingly, if there are multiple choices.

If neither gnu or musl is present in the asset string, it is 99% accurate to assume the asset is for glibc.

@dufferzafar
Copy link
Contributor

@benjaminbauer eget already does system detection. There's no clear winner among libc/musl. You might want either depending on the conditions.

For cases where I know the musl build works fine, I usually do: eget sharkdp/fd -a musl

@benjaminbauer
Copy link

benjaminbauer commented Jul 8, 2024

@dufferzafar I am aware of the system detection in terms of OS family and CPU architecture. But the used syscall lib is missing imo. For the majority of linux users/setups it is very clear if they are using musl or glibc, think debian or alpine. Only in a development setup one might have both present. I assume even then, the linker present in the path will use one or the other without explicit configuration.

My (medium) hassle with this in combination with eget is, that I use eget as a cross platform package manger with a central eget.toml. In the cases where a musl asset is present in the release, I have to explicitly select gnu/glibc for linux systems. I also run eget on MacOs, making my eget.toml more messy (if linux, then asset = ["gnu"] - the if is via chezmoi).

Also I cannot set the asset filter globally on linux, because repos that do not have a musl release, also usually do not have gnu/glibc explicitly in the release asset name.

@commiyou
Copy link
Author

commiyou commented Jul 8, 2024

Sorry, I didn’t clearly explain my requirements. I am working on a CentOS 6.3 server, and the system’s built-in glibc doesn’t support GLIBC_2.34. So, is there a musl version of eget that can be released?

zyedidia added a commit that referenced this issue Jul 9, 2024
@zyedidia
Copy link
Owner

zyedidia commented Jul 9, 2024

Ah, the builds are supposed to be made statically but it looks like in the latest release there was a problem, I will reupload a static version.

@zyedidia
Copy link
Owner

zyedidia commented Jul 9, 2024

I just updated the 1.3.4 Linux AMD64 binary (the only non-static binary) on the releases page.

@zyedidia zyedidia closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants