unexpected script termination - entrypoint-router.sh #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue raised in zyclonite#15 where `entrypoint-router.sh` exits after telling the pipe listener process to go away, with the result that the temporary pipe file does not get cleaned up on a container restart. > The temporary pipe file is not persisted so it will always get cleaned up when the container is terminated or recreated. The pipe listener process exits automatically without needing any signal from `entrypoint-router.sh` so the script lines doing that are removed. Instead of creating the pipe file using `mktemp` with a random suffix, the hard-coded name "/tmp/zerotier-ipc-log" will be used. The pipe file is: * still in `/tmp` so it is not persisted and will get cleaned up when the container is terminated. * always initalised empty each time the script runs (important if the container restarts). Fixes: zyclonite#15 Signed-off-by: Phill Kelley <[email protected]>
|
Tested updated router-main. Works as expected on my Raspberry Pis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue raised in #15 where
entrypoint-router.shexits aftertelling the pipe listener process to go away, with the result that the
temporary pipe file does not get cleaned up on a container restart.
The pipe listener process exits automatically without needing any signal
from
entrypoint-router.shso the script lines doing that are removed.Instead of creating the pipe file using
mktempwith a random suffix,the hard-coded name "/tmp/zerotier-ipc-log" will be used. The pipe file
is:
still in
/tmpso it is not persisted and will get cleaned up whenthe container is terminated.
always initalised empty each time the script runs (important if the
container restarts).
Fixes: #15
Signed-off-by: Phill Kelley [email protected]