feat(ui): updates to dark mode logic #3740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9362246394Details
💛 - Coveralls |
robertsLando
requested changes
Jun 3, 2024
| @@ -666,6 +669,8 @@ export default { | |||
| hideTopbar: false, | |||
| title: '', | |||
| messages: [], | |||
| systemDark: false, | |||
| mq_system_dark: null, | |||
There was a problem hiding this comment.
why don't use a watch for this instead?
There was a problem hiding this comment.
Also it's not clear to me what mq_system_dark is used for, you never re-assign it, I would instead use a let in beforeMount instead
There was a problem hiding this comment.
First time using Vue. Will re look at the logic here. Thanks for the notes.
There was a problem hiding this comment.
It's ok no worries I appreciate a lot your help 🙏🏼
Comment on lines
+1632
to
+1639
| beforeUnmount() { | ||
| if (this.mq_system_dark !== null) { | ||
| this.mq_system_dark.removeEventListener( | ||
| 'change', | ||
| this.updateSystemDark, | ||
| ) | ||
| } | ||
| }, |
There was a problem hiding this comment.
this is a bit useless as the App will only be unmounted when the page is destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
nullas system defined.TODO
Testing Artifacts