fix: Address GitHub workaround for CVE-2022-24765. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this fixes it on its own. I've run a build with I suspect it might be related to actions/checkout#766 This is not an argument against merging this PR, it should be updated regardless. |
|
I just added the actions/checkout#766 workaround in this PR as well. Currently testing. |
2363d8b
to
2957a94
Compare
|
I have confirmed that the fix in this PR is necessary. You can see it running successfully in https://github.com/rht/zulip-archive-sample/actions. |
This commit: - updates GH Actions checkout to v3 - apply additional work around stated in actions/checkout#766 This fixes the problem with the following error message: ``` fatal: unsafe repository ('/github/workspace' is owned by someone else) To add an exception for this directory, call: git config --global --add safe.directory /github/workspace ``` The problem is due to the security fix from the Git security vulnerability recently announced: https://github.blog/2022-04-12-git-security-vulnerability-announced/. Relevant GH issue: actions/checkout#760
SaschaMann
approved these changes
Apr 15, 2022
|
Merged, thanks @rht and @SaschaMann! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with the following error message:
The problem is due to the security fix from the Git security vulnerability
recently announced:
https://github.blog/2022-04-12-git-security-vulnerability-announced/.
Relevant GH issue: actions/checkout#760